Basic python coding

Question

Trying to do a simple guessing game program in python, but I'm more comfortable in java. When the correct number is entered, it says it is too high and won't exit the while loop. Any suggestions?

import random
comp_num = random.randint(1,101)
print comp_num
players_guess = raw_input("Guess a number between 1 and 100: ")
while players_guess != comp_num:
    if players_guess > comp_num:
        print "Your guess is too high!"
    elif players_guess < comp_num:
        print "Your guess is too low!"
    players_guess = raw_input("Guess another number between 1 and 100: ")
print "CONGRATULATIONS! YOU GUESSED CORRECTLY!"

it is not a good idea to keep updating your question to reflect the answers (even if the answers are correct). It makes the answers look irrelevant, and removes any chance of other learning from your errors. — Tony Suffolk 66
– Tony Suffolk 66, Commented Oct 30, 2014 at 0:25
Some IDEs like PyCharm come with a handy debugger. Saves time asking questions online. — maksimov
– maksimov, Commented Oct 30, 2014 at 0:25

ugo · Accepted Answer · 2014-10-30 00:19:00Z

8

I would guess it is because you are comparing string and int. Whatever is captured from raw_input is captured as a string and, in Python:

print "1" > 100    # Will print true

For it to work, convert:

players_guess = raw_input("Guess a number between 1 and 100: ")

to

players_guess = int(raw_input("Guess a number between 1 and 100: "))

answered Oct 30, 2014 at 0:19

ugo

2,6962 gold badges31 silver badges34 bronze badges

Sign up to request clarification or add additional context in comments.

5 Comments

Max Regitnig Over a year ago

thanks, guys! but it still won't exit the while loop once I enter the right number..

maksimov Over a year ago

Or perhaps you forgot to cast your second raw_input to an int... like your updated question indicates. You should not update your question with answers, since you're only confusing things.

ugo Over a year ago

@MaxRegitnig like maksimov says, you probably forgot to cast your second raw_input at the bottom of the loop.

Padraic Cunningham Over a year ago

or just make 100 a string

Jonathon Reinhart Over a year ago

Welcome to the wonderful world of dynamic typing. You'll learn to love it as much as hate it.

khelwood · Accepted Answer · 2014-10-30 00:19:03Z

5

You are comparing a string to an int. That's why you get odd results.

Try this:

players_guess = int(raw_input("Guess a number between 1 and 100: "))

answered Oct 30, 2014 at 0:19

khelwood

59.7k14 gold badges91 silver badges116 bronze badges

Comments

Hackaholic · Accepted Answer · 2014-10-30 00:31:55Z

0

import random
comp_num = random.randint(1,101)
print comp_num
players_guess = int(raw_input("Guess a number between 1 and 100: "))
while players_guess != comp_num:
    if players_guess > comp_num:
        print "Your guess is too high!"
    elif players_guess < comp_num:
        print "Your guess is too low!"
   players_guess = int(raw_input("Guess another number between 1 and 100: "))
print "CONGRATULATIONS! YOU GUESSED CORRECTLY!"

you need to force the input to int

edited Oct 30, 2014 at 0:31

answered Oct 30, 2014 at 0:21

Hackaholic

19.8k6 gold badges59 silver badges77 bronze badges

3 Comments

Tony Suffolk 66 Over a year ago

you missed the int from the 2nd raw_input call.

Hackaholic Over a year ago

yea it was a typing mistake, down voting is not a soln

Tony Suffolk 66 Over a year ago

for what it is worth - I didn't downvote, I just stated a reason why someone might have done so - it does seem a little harsh to me.

Uddeshya Singh · Accepted Answer · 2015-08-30 14:57:30Z

0

Try this code:

import random
comp_num = random.randint(1,101)
print comp_num
players_guess = int(raw_input("Guess a number between 1 and 100: "))
while players_guess != comp_num:
    if players_guess > comp_num:
        print "Your guess is too high!"
    elif players_guess < comp_num:
        print "Your guess is too low!"
    players_guess = int(raw_input("Guess another number between 1 and 100: "))
print "CONGRATULATIONS! YOU GUESSED CORRECTLY!"

answered Aug 30, 2015 at 14:57

Uddeshya Singh

214 bronze badges

1 Comment

dakab Over a year ago

You could improve your answer by adding a short explanation.

Shubh Patel · Accepted Answer · 2022-03-16 04:55:39Z

0

in your code change in print formation and use 'int' datatype in numerical argument. i will change the cond so try it once:

    import random
comp_num = random.randint(1,101)
print ('comp_num')
players_guess = int(raw_input("Guess a number between 1 and 100: "))
while players_guess != comp_num:
    if players_guess > comp_num:
        print('Your guess is too high!')
    elif players_guess < comp_num:
        print('Your guess is too low!')
    players_guess = int(raw_input("Guess another number between 1 and 100: "))
print('CONGRATULATIONS! YOU GUESSED CORRECTLY!')

answered Mar 16, 2022 at 4:55

Shubh Patel

791 silver badge6 bronze badges

Collectives™ on Stack Overflow

Basic python coding

5 Answers 5

5 Comments

Comments

3 Comments

1 Comment

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

5 Answers 5

5 Comments

Comments

3 Comments

1 Comment

Comments

Your Answer

Sign up or log in

Post as a guest

Related