PHP: how to return counter of value from recursive function?

Question

function count($array){ 

    $counter=0;
    foreach($array as $key=>$value){ 
    if(is_array($value)){ 
            count($value); 
        }else{
            if(strcmp($value, "Hi") == 0){
                $counter++;
            }
        }
    }
}

$arrays = array("Hi", "a", "Hi", "b", "c", array("c", "Hi", array("Hi"), "d"));

If I call count($arrays); I want to print 4 in this case.
But my code keeps printing 0. It seems it does not return counter of "Hi" properly but I have no idea.

count() is a reserved function! And why you want to print 4?!? — Rizier123
– Rizier123, Commented Nov 8, 2014 at 14:56
@Rizier123: I guess because "Hi" is present 4 times in that array — dynamic
– dynamic, Commented Nov 8, 2014 at 15:08

dynamic · Accepted Answer · 2014-11-08 15:11:52Z

3

count() is a built-in function of PHP, better if you change the name:

function myRecursiveCount($array, $needle = "Hi"){ 
   $counter=0;
   foreach($array as $value){ 
     if(is_array($value)){ 
       $counter += myRecursiveCount($value); 
     } else if ($value === $needle){
       $counter++;  
     }
   }
   return $counter;
}

$inputs = array("Hi", "a", "Hi", "b", "c", array("c", "Hi", array("Hi"), "d"));
echo myRecursiveCount($inputs); // Prints 4

You need two edits:

the function should return the $counter;
in the recursive call you should append the result: $counter += f();.

I have also applied two optional improvements:

you don't need to populate the variable $key as you don't need it
to compare two strings you can simply use == comparison operator (strcmp feels so old)

Live on codepad: http://codepad.org/ATiKV09d

edited Nov 8, 2014 at 15:11

answered Nov 8, 2014 at 14:55

dynamic

48.2k56 gold badges163 silver badges236 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

ekad Over a year ago

I guess $counter += count($value); should be $counter += myRecursiveCount($value);?

Collectives™ on Stack Overflow

PHP: how to return counter of value from recursive function?

1 Answer 1

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related