Calling The Same Function Repeatedly In Python

Question

I've written a little function with a replace() to clean up redirect files to strip out the logic and essentially leave in the pure English.

So far I've got:

def redir_cleanup(searchFor, replaceWith):
    inputFile = open('input', 'r')
    outputFile = open('output', 'w+')   

    for line in inputFile:
        print "Replacing %s with '%s'" % (searchFor, replaceWith)
        outputFile.write(line.replace(searchFor, replaceWith))

redir_cleanup("RedirectMatch permanent ", "")
redir_cleanup("RewriteRule ^", "")
redir_cleanup(" [L,R=301]", "")
redir_cleanup("RewriteCond %{QUERY_STRING} ^search\=(", "")
redir_cleanup(")$ [NC]", "")
redir_cleanup("\+", " ")
redir_cleanup("[NC,OR]", "")
redir_cleanup("RewriteRule ^.* ", "")

But it only strips the top call, do I need to loop them somehow?

I haven't checked to see if this solves your problem, but it may be useful to close your files at the end of the function. (or use with). — Kevin
– Kevin, Commented Nov 17, 2014 at 16:30
Thanks, it didn't solve the issue, but I forgot the closes in this rewrite. I've been playing with it and written it a few times :) — Dave Melia
– Dave Melia, Commented Nov 17, 2014 at 16:32
You need to apply each filter to each line in the file. So you got this inside out. — Lennart Regebro
– Lennart Regebro, Commented Nov 17, 2014 at 16:43
I thought that's what I was doing with "for line in file". I assumed it would iterate through the file for as long as the function was called with different parameters. — Dave Melia
– Dave Melia, Commented Nov 17, 2014 at 16:47
I'm debating just sticking everything in a list and iterate through that instead. — Dave Melia
– Dave Melia, Commented Nov 17, 2014 at 16:52

Ignacio Vazquez-Abrams · Accepted Answer · 2014-11-17 16:38:30Z

1

Your function reads from a file with one name, and then writes to a file with a different name. But the names never change, so it keeps using the same input. Try opening the files outside of the function and passing them in.

answered Nov 17, 2014 at 16:38

Ignacio Vazquez-Abrams

804k160 gold badges1.4k silver badges1.4k bronze badges

Sign up to request clarification or add additional context in comments.

Collectives™ on Stack Overflow

Calling The Same Function Repeatedly In Python

1 Answer 1

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

Comments

Your Answer

Sign up or log in

Post as a guest

Related