PreparedStatement MySQLSyntaxErrorException using valid query string [duplicate]

Question

I've spent hours looking at what seems like what should be perfectly working code. The connection.createStatement() version of this method works fine but as soon as I try to convert it over to the better, connection.prepareStatement() version it throws a MySQLSyntaxErrorException and complains about a problem near the '?' character in my query string. The code is posted below and I simply cannot see the problem with it. The database field is VARCHAR and accepts Strings so that is not the problem.

    public Discussion getDbDiscussionInstance(String _instanceId) throws SQLException {

    String qryStr = null;
    PreparedStatement myStmt = null;
    ResultSet myRs = null;

    // Try to build the object with existing data.
    try {
        qryStr = "SELECT assignment_id, discussion_id, section_id, user_id, circle_id, breakout_id, title, description, created, due FROM macb_discussions WHERE instance_id=?";
        myStmt = connection.prepareStatement(qryStr);
        myStmt.setString(1, _instanceId);
        myRs = myStmt.executeQuery(qryStr);
        if (rs.next()) {
            this.discussionId = myRs.getString("discussion_id");
        }
    } catch (SQLException e) {
        dbFunc.catchSQLException(e);
    } finally {
        myRs.close();
        myStmt.close();
    }
}

can u pls include the exact exception

Ankur Singhal
– Ankur Singhal

2014-11-21 13:57:13 +00:00
Commented Nov 21, 2014 at 13:57 — Ankur Singhal
– Ankur Singhal, Commented Nov 21, 2014 at 13:57

Master Slave · Accepted Answer · 2014-11-21 13:59:17Z

2

Use only myStmt.executeQuery(); without the argument, you have already preperad the statement

answered Nov 21, 2014 at 13:59

Master Slave

28.6k4 gold badges61 silver badges56 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Ankur Singhal · Accepted Answer · 2014-11-21 14:01:42Z

0

From the docs,

Statement.executeQuery(String sql)

PreparedStatement.executeQuery()

So change your function accordingly. myStmt = connection.prepareStatement(qryStr); to

 myStmt = connection.prepareStatement();

answered Nov 21, 2014 at 14:01

Ankur Singhal

26.1k17 gold badges92 silver badges129 bronze badges

Collectives™ on Stack Overflow

PreparedStatement MySQLSyntaxErrorException using valid query string [duplicate]

2 Answers 2

Comments

Comments

Linked

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

Comments

Linked

Related