Appending javascript to div with jquery

Question

I'm trying to append the following javascript to a div that will appear when the user presses the ESC key. I can't seem to get the JavaScript to display the value of the javascript being used:

    $("#json").hide();
    $(document).keydown(function (e) {
    if (e.keyCode == 27) {
         $("#json").append("<script type="text/javascript"> + "window.location.href = '/editorialPortal' + '?' + this.id + '=' + this.options[this.selectedIndex].value;" + "</" + script>").toggle();
    }
});

I'm not sure where I'm missing string escaping or a quotation mark.

What? You want to go to a new page when the user presses escape? — tymeJV
– tymeJV, Commented Dec 17, 2014 at 20:41
No, that JavaScript pulls the current URI plus another parameter from a dropdown, which is used to provide results from the dropdown selection. This javascript should show the current URI based on that selection, which is being hidden from the basic user. — Matt
– Matt, Commented Dec 17, 2014 at 20:43
Well this doesn't refer to a dropdown, it refers to the document - and window.location.href is used to change the page location, and toggle is used to hide and show an element... there's a lot wrong. What is your end goal? — tymeJV
– tymeJV, Commented Dec 17, 2014 at 20:44
Ignore the dropdown selection part(I was explaining the use of that URI). The idea is to simply grab the current URI and append it to the div that is being triggered on keypress. — Matt
– Matt, Commented Dec 17, 2014 at 20:46

Adam Denoon · Accepted Answer · 2014-12-17 20:48:16Z

1

Try e.which rather than e.keyCode

Also, since you opened the string with double quotes, you cannot use double quotes in the string (open it with single quotes, and only use single-quotes when you want to use ' + ' or close the whole string).

answered Dec 17, 2014 at 20:48

Adam Denoon

3291 silver badge16 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Ted · Accepted Answer · 2014-12-17 21:14:26Z

0

I think the problem is with the quotes:

$('#json').append('<' + script type="text/javascript">window.location.href = "/editorialPortal?' + this.id + '=' + this.options[this.selectedIndex].value + '"  </' + 'script>').toggle();

In this example, I use single quotes in defining strings, so the double quotes can be used inside it.

Also, be sure to include jQuery in your fiddles. The above code works except that it errors on the undefined variables this.options[this.selectedIndex].value and this.id. Breaking up of the script tags is to make jsfiddle happy.

edited Dec 17, 2014 at 21:14

answered Dec 17, 2014 at 21:03

Ted

14.9k2 gold badges43 silver badges58 bronze badges

Collectives™ on Stack Overflow

Appending javascript to div with jquery

2 Answers 2

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related