Execute functions whose names are in an array

Question

I've seen How to execute a JavaScript function when I have its name as a string, Calling a JavaScript function named in a variable, Can I use the value of a variable to initiate a function?, but I can't figure out how to get this working with an array and a for loop.

What I've tried:

I have a few functions, let's say:

function one() { 
    alert('one');
}

function two() {
    alert('two');
}

function three() {
    alert('three');
}

and an array:

callThese = ['one', 'two']

and I want to call one and two.

This doesn't work:

for (i = 0; i < callThese.length; ++i) {
    //console.log(callThese[i]); <--- (outputs one and two)
    window[callThese[i]]();
}

The error I get is TypeError: object is not a function. The functions are definitely there, and they work by calling them manually (ie. one(), two(), etc...).

Sorry if this is a basic mistake, but how do I get this working?? I don't mind a jQuery solution if there is one.

newbies seem to do this quite often, use function names stored in strings, and then wanting to call the functions. Don't , there are surely better ways to do this, for instance storing actual references to the functions instead of strings. — adeneo
– adeneo, Commented Jan 10, 2015 at 17:03
If it says object is not a function then window[callThese[i]] is not a function. What is it? — Halcyon
– Halcyon, Commented Jan 10, 2015 at 17:04
The error suggests the functions aren't globals. If they're defined within another function, they won't be properties of window. — Jonathan Lonowski
– Jonathan Lonowski, Commented Jan 10, 2015 at 17:05
@ṧнʊß yes, but what is window.one, window.two, etc.? — Halcyon
– Halcyon, Commented Jan 10, 2015 at 17:06

Michał Szepielak · Accepted Answer · 2015-01-10 17:08:39Z

4

You need to assign functions to your object. It's not recommended to create global functions (other scripts/frameworks can overwrite them).

var obj = {
        one: function () {
            alert('one');
        },
        two: function () {
            alert('two');
        },
        three: function () {
            alert('three');
        }
    },
    callThese = ['one', 'two'];

for (var i = 0; i < callThese.length; ++i) {
    obj[callThese[i]]();
}

answered Jan 10, 2015 at 17:08

Michał Szepielak

2841 silver badge4 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

charlietfl · Accepted Answer · 2015-01-10 17:10:14Z

1

You can create an object that contains the functions

var myFuncs = {
    one: function () {
        alert('one');
    },
    two: function () {
        alert('two');
    }
}

for (i = 0; i < callThese.length; ++i) {        
    myFuncs[callThese[i]]();
}

answered Jan 10, 2015 at 17:10

charlietfl

172k14 gold badges125 silver badges154 bronze badges

Collectives™ on Stack Overflow

Execute functions whose names are in an array

2 Answers 2

Comments

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related