External JavaScript function undefined, but exists

Question

I have 2 files, one HTML, one JavaScript.

JavaScript File (contacts.js):

function add_contact() {
    // Rest of Code here
}

HTML File:

<script src="/assets/js/contacts.js" type="javascript/text"></script>

I have a button that when it's clicked, it calls the 'add_contact' function:

<button type="button" class="btn btn-primary" onclick="add_contact();">Save changes</button>

When the JavaScript code is the head of the HTML file, the function works fine. However, now it's part of the external file, it returns the following error:

Uncaught ReferenceError: add_contact is not defined

I feel a bit lost over this one, so any help would be fantastic!

@JamesMcDonnell: Good catch on that! Actually the type attribute can just be removed. :-) — gen_Eric
– gen_Eric, Commented Jan 13, 2015 at 19:02
@RocketHazmat No, the function is the very first line in the .js file — Parker1090
– Parker1090, Commented Jan 13, 2015 at 19:03
Actually, @JamesMcDonnell that seems to have fixed it! Thank you very much :) — Parker1090
– Parker1090, Commented Jan 13, 2015 at 19:04

James McDonnell · Accepted Answer · 2015-01-13 19:12:28Z

7

Type should be text/javascript not javascript/text

answered Jan 13, 2015 at 19:12

James McDonnell

3,7101 gold badge23 silver badges26 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Adrian Salazar · Accepted Answer · 2015-01-13 19:08:58Z

3

Change this block of markup:

<script src="/assets/js/contacts.js" type="javascript/text"></script>

to:

<script src="/assets/js/contacts.js" type="text/javascript"></script>

answered Jan 13, 2015 at 19:08

Adrian Salazar

5,32936 silver badges52 bronze badges

Collectives™ on Stack Overflow

External JavaScript function undefined, but exists

2 Answers 2

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related