How to update variable in JS

Question

How can i update variable from function? I have this. But both variables still "0" after "updateFilter()". How can i do this without run "loadAjax(var1, var2)" from slider function?

var var1 = 0,
    var2 = 0;

$("#slider").slider({
    // options...
    stop: function( event, ui ) {
        var var1 = ui.values[ 0 ], // <- changes on move
            var2 = ui.values[ 1 ]; // <- changes on move
        updateFilter();
    }
});

function updateFilter() {
    loadAjax(var1, var2);
}

sorry for my english

Pranay Rana · Accepted Answer · 2015-01-14 13:47:03Z

1

Problem with you code is you are defining same varible you defined in global scope

var var1 = 0,
    var2 = 0;

//in function below you are redefining var1 and var2 varible please dont do that 
 stop: function( event, ui ) {
        var var1 = ui.values[ 0 ], // <- changes on move
            var2 = ui.values[ 1 ]; // <- changes on move
        updateFilter();

instead of above code stop method should be

 stop: function( event, ui ) {
            var1 = ui.values[ 0 ], // <- changes on move
            var2 = ui.values[ 1 ]; // <- changes on move
        updateFilter();

why dont you pass varible to function directly like this

updateFilter(var1, var2);


function updateFilter(var1, var2) {
    loadAjax(var1, var2);
}

answered Jan 14, 2015 at 13:47

Pranay Rana

177k37 gold badges244 silver badges267 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

tenRabbits Over a year ago

Oh, thanks! It works (im new in JS and didn't know these details)

Master Slave · Accepted Answer · 2015-01-14 13:51:30Z

0

http://jsfiddle.net/kcg1hmsu/

your values are 0, because you're shadowing your global variables, you can simply remove the var inside the stop function

$("#slider").slider({
    // options...
    stop: function( event, ui ) {
         var1 = ui.values[ 0 ], // <- changes on move
         var2 = ui.values[ 1 ]; // <- changes on move
         console.log(var1, var2);
        updateFilter();
    }
});

answered Jan 14, 2015 at 13:51

Master Slave

28.6k4 gold badges61 silver badges56 bronze badges

Collectives™ on Stack Overflow

How to update variable in JS

2 Answers 2

1 Comment

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

1 Comment

Comments

Your Answer

Sign up or log in

Post as a guest

Related