php javascript autopopulated image gallery

Question

I get the error message syntax error missing ; before statement at "var galleryarray=new Array();" . "\n"; here is the php code

function returnimages($dirname=".") {
    $pattern="\.(jpg|jpeg|png|gif|bmp)$";
    $files = array();$curimage=0;
    if($handle = opendir($dirname)) {
        while(false !== ($file = readdir($handle))){
            if(eregi($pattern, $file)){
                echo 'galleryarray[' . $curimage .']=["' . $file . '"];' . "\n";
                $curimage++;
            }
        }
    closedir($handle);
    }
    return($files);
}
echo "var galleryarray=new Array();" . "\n";
returnimages();

and here is the javascript:

var galleryarray=new Array(); 
var curimg=0
function rotateimages(){
    document.getElementById("slideshow").setAttribute("src", "slideshow_images/"+galleryarray[curimg])
    curimg=(curimg<galleryarray.length-1)? curimg+1 : 0
}
window.onload=function(){
    setInterval("rotateimages()", 2500)
}

i just don't see my mistake any help with this problem would be appreciated

klein

var curimg=0 miss a semicolumn at the end

Marco Mura
– Marco Mura

2015-01-29 08:21:46 +00:00
Commented Jan 29, 2015 at 8:21 — Marco Mura
– Marco Mura, Commented Jan 29, 2015 at 8:21

Code Lღver · Accepted Answer · 2015-01-29 09:11:56Z

1

Replace your below line:

echo "var galleryarray=new Array();" . "\n";

with the following line:

echo "<script>var galleryarray=new Array();</script>";

You are adding a JS code without script tag so you need to add this tag.

EDITED:

echo 'galleryarray[' . $curimage .']=["' . $file . '"];' . "\n";

You also have error in the above line replace it with the below line:

echo '<script>galleryarray["' . $curimage .'"]=["' . $file . '"];</script>';

edited Jan 29, 2015 at 9:11

answered Jan 29, 2015 at 8:20

Code Lღver

15.6k16 gold badges61 silver badges75 bronze badges

Sign up to request clarification or add additional context in comments.

8 Comments

klein morgan Over a year ago

thanks for the help code lover but now I get the error msg syntax error; expected statement got <

Code Lღver Over a year ago

@kleinmorgan replace double quota " with single quota ' and then try. hope this will work

klein morgan Over a year ago

I have tried replacing the double quotes with singles but now I get

klein morgan Over a year ago

syntax error missing; before statement echo 'galleryarray[' . $curimage .']=["' . $file . '"];' . "\n";

klein morgan Over a year ago

thanks marco mura but adding the semicolumn does not bring the rest of the images. the gallery is still getting stuck on the first image

|

Collectives™ on Stack Overflow

php javascript autopopulated image gallery

1 Answer 1

8 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

8 Comments

Your Answer

Sign up or log in

Post as a guest

Related