Bash Script_ Inserting variable read from read command into command

Question

I am working on a project using the BLS API.
Reference: http://www.bls.gov/developers/api_unix.htm

My current script follows:

declare  id=""
echo -n "Enter id: "
read id
echo -n "enter startyear: "
read startyear
echo -n "enter endyear: "
read endyear


curl -i -X POST -H 'Content-Type: application/json' -d '{"seriesid":      ["$id"], "startyear":'$startyear' , "endyear":'$endyear'}' http://api.bls.gov/publicAPI/v2/timeseries/data/

I have edited it and put in the ID by hand like on the reference page and that worked. I cannot seem to read the $id from input and insert it into the curl command. Any assistance with this is greatly appreciated thank you.

edit1:

I updated the code and changed the quotes for the {} for the -d option to double quotes and the same error persists.

edit2:

after updating the file with the code provided in the comments I receive a:

Warning:  You can only select one HTTP request!

when I run it.

The variable $id is not being expanded because it is inside single quotes. — Phylogenesis
– Phylogenesis, Commented Mar 13, 2015 at 15:44
I copied and pasted the code snippet into a new file and it worked. If I want to read up on why where would you suggest I go? — Matthew King
– Matthew King, Commented Mar 13, 2015 at 16:28
As I said above, the warning from curl suggested that you were using -I (make a HEAD request) rather than -i (include response headers). An HTTP request cannot be both a HEAD request and a POST request. — Phylogenesis
– Phylogenesis, Commented Mar 13, 2015 at 16:30

Phylogenesis · Accepted Answer · 2015-03-13 15:57:38Z

1

To clear up any confusion in my comment above, the following should work:

echo -n "Enter id: "
read id
echo -n "enter startyear: "
read startyear
echo -n "enter endyear: "
read endyear

curl -i \
     -X POST \
     -H 'Content-Type: application/json' \
     -d "{\"seriesid\":[\"${id}\"],\"startyear\":\"${startyear}\",\"endyear\":\"${endyear}\"}" \
     http://api.bls.gov/publicAPI/v2/timeseries/data/

answered Mar 13, 2015 at 15:57

Phylogenesis

7,90024 silver badges27 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Dragan · Accepted Answer · 2015-03-13 15:45:20Z

0

Your -d argument is surrounded by ' single quotes which dont allow variable interpolation. Use double quotes "args $id "

answered Mar 13, 2015 at 15:45

Dragan

4554 silver badges12 bronze badges

Collectives™ on Stack Overflow

Bash Script_ Inserting variable read from read command into command

2 Answers 2

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related