controller is undefined error (already defined in javascript file)

Question

Uncaught Error: [$injector:modulerr] Failed to instantiate module app due to:
Error: [$injector:modulerr] Failed to instantiate module app.Firstpage due to:
ReferenceError: loginController is not defined
    at routerChange (http://127.0.0.1:1139/www/js/Firstpage/route.js:9:41)
    at Object.invoke (http://127.0.0.1:1139/www/lib/ionic/js/ionic.bundle.js:12110:17)
    at runInvokeQueue (http://127.0.0.1:1139/www/lib/ionic/js/ionic.bundle.js:12016:35)
    at http://127.0.0.1:1139/www/lib/ionic/js/ionic.bundle.js:12025:11
    at forEach (http://127.0.0.1:1139/www/lib/ionic/js/ionic.bundle.js:8248:20)
    at loadModules (http://127.0.0.1:1139/www/lib/ionic/js/ionic.bundle.js:12006:5)
    at http://127.0.0.1:1139/www/lib/ionic/js/ionic.bundle.js:12023:40
    at forEach (http://127.0.0.1:1139/www/lib/ionic/js/ionic.bundle.js:8248:20)
    at loadModules (http://127.0.0.1:1139/www/lib/ionic/js/ionic.bundle.js:12006:5)
    at createInjector (http://127.0.0.1:1139/www/lib/ionic/js/ionic.bundle.js:11932:11)

Hello I am trying to make angular app .But I am getting error that my controller is undefined .could you please tell me where i am doing wrong ? I am getting the above error here is my code . https://dl.dropbox.com/s/zipm6g0ewqf7xg4/ionic_web.zip?dl=0

I am trying to load index.html file .Please run index.html file to get error

<html ng-app="app">
<head>
    <meta charset="utf-8">
    <meta name="viewport" content="initial-scale=1, maximum-scale=1, user-scalable=no, width=device-width">

    <title>First app</title>

    <link href="lib/ionic/css/ionic.css" rel="stylesheet">

    <!-- libraray--->
     <script src="lib/ionic/js/ionic.bundle.js" type="application/javascript"></script>  




    <!-- module  -->
   <script src="js/Firstpage/module.js" type="application/javascript"></script>




    <!-- controller  -->
<script src="js/Firstpage/controller/firstcontroller.js" type="application/javascript"></script>

     <!-- router -->
    <script src="js/Firstpage/route.js" type="application/javascript"></script>


    <script src="js/app.js" type="application/javascript"></script>

</head>
<body>

    <ion-nav-bar class="bar-balanced">
        <ion-nav-back-button class="">
        </ion-nav-back-button>
    </ion-nav-bar>

    <ion-nav-view></ion-nav-view>




</body>
</html>

here is my whole code

https://dl.dropbox.com/s/zipm6g0ewqf7xg4/ionic_web.zip?dl=0

roxid · Accepted Answer · 2015-03-27 09:14:20Z

2

Previously :

in Route.js -

(function(){
   'use strict';
   angular.module('app.Firstpage').config(routerChange);
    routerChange.$inject=['$stateProvider', '$urlRouterProvider'];
    function routerChange($stateProvider,$urlRouterProvider){
        $stateProvider.state('login',{
                             url:'/login',
                             templateUrl:"js/Firstpage/template/login.html",
                             controller:'loginController'

        })

        $urlRouterProvider.otherwise('/login')
    }


})();

Now Route.js :

(function(){
   'use strict';
   angular.module('app.Firstpage').config(routerChange);
    routerChange.$inject=['$stateProvider', '$urlRouterProvider'];
    function routerChange($stateProvider,$urlRouterProvider){
        $stateProvider.state('login',{
                             url:'/login',
                             templateUrl:"js/Firstpage/template/login.html",
                             controller:'loginController'

        })

        $urlRouterProvider.otherwise('/login')
    }


})();

you missed the single quote.

controller:'loginController'

Output screenshot: Output image

edited Mar 27, 2015 at 9:14

answered Mar 27, 2015 at 9:12

roxid

5034 silver badges15 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

user944513 Over a year ago

wait I am checking ..will tell you

Alireza Savand Over a year ago

The OP is still checking!

Collectives™ on Stack Overflow

controller is undefined error (already defined in javascript file)

1 Answer 1

2 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

2 Comments

Your Answer

Sign up or log in

Post as a guest

Related