For each loop in PHP erroring out "invalid argument supplied"

Question

I'm trying to get this function to work but for some reason it errors out on the foreach line saying there is an invalid argument.

$scores= TESTAPI::GUL($user->ID);
if (empty($scores)) {
    echo "<p>No Scores</p>";
} else {
    foreach ($scores as $score) {
        echo "<p>".$score."</p>";
    }
}

The error I get is: PHP Warning: Invalid argument supplied for foreach()

Add var_dump($scores); before the foreach line. What is the output? — Mex
– Mex, Commented Apr 16, 2015 at 9:20

Erik Theoboldt · Accepted Answer · 2015-04-16 09:26:41Z

2

For example, empty('') would also be true.

I would recommend to check is_array($scores) && count($scores) instead of empty(), to make sure the api returned useable output (an array) and that this contains elements (count() > 0 which is true).

answered Apr 16, 2015 at 9:26

Erik Theoboldt

2,7282 gold badges18 silver badges21 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

jeromegamez · Accepted Answer · 2015-04-16 09:23:23Z

1

$scores = TESTAPI::GUL($user->ID);

if (is_array($scores) && count($scores)) {
    foreach ($scores as $score) {
        echo "<p>".$score."</p>";
    }
} else {
    echo "<p>No Scores</p>";
}

answered Apr 16, 2015 at 9:23

jeromegamez

3,5711 gold badge25 silver badges38 bronze badges

3 Comments

Ryflex Over a year ago

I did the following using similar to what you put and it works perfectly: if(!is_array($scores) && !count($scores)){

Erik Theoboldt Over a year ago

Be careful, expression (!is_array($scores) && !count($scores)) will also be true if $scores=false, so you might get unexpected results.

jeromegamez Over a year ago

Perfectly fine answer. I'd just like to add that && count($scores) can safely be removed - if it's an empty array, the loop will not be entered anyways.

Sougata Bose · Accepted Answer · 2015-04-16 09:29:27Z

1

Try this -

 foreach ((array) $scores as $score) { ...

answered Apr 16, 2015 at 9:29

Sougata Bose

31.8k8 gold badges52 silver badges89 bronze badges

1 Comment

jeromegamez Over a year ago

Just as a general notice: Type casting to an array could have unwanted side effects, e.g. if a value is an object.

D.Dimitrioglo · Accepted Answer · 2017-07-05 18:50:47Z

1

Looks like $scores is neither an array nor an object...

edited Jul 5, 2017 at 18:50

answered Apr 16, 2015 at 9:24

D.Dimitrioglo

3,6632 gold badges25 silver badges43 bronze badges

2 Comments

James Watkins Over a year ago

Can you provide some additional context such as documentation to support this theory?

D.Dimitrioglo Over a year ago

Here you are github.com/php/php-src/blob/…

Collectives™ on Stack Overflow

For each loop in PHP erroring out "invalid argument supplied"

4 Answers 4

Comments

3 Comments

1 Comment

2 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

4 Answers 4

Comments

3 Comments

1 Comment

2 Comments

Your Answer

Sign up or log in

Post as a guest

Related