PHP calling function from another file not working

Question

Very basically, I'm trying to set the value of a variable in one file based on the return value of a function in another file. This is then returned via AJAX, however, the AJAX always seems to indicate an error. Code below:

updateTurn.php

<?php
//This is called by AJAX
require_once('functions.php'); //include necessary file
$player = getCurrentTurn(); //call function 
echo $player;
?>

functions.php

...
function getCurrentTurn()
{
    //the query and connection function appropriately
    include_once("getConn.php");
    $query = $GLOBALS['conn']->prepare("SELECT turn FROM Game");
    $query->execute();
    $result=$query->fetch(PDO::FETCH_ASSOC);
    return $result['turn']; //return the result of the query
}
...

AJAX

function checkForTurnChange(){
    $.ajax({
        type:"GET",
        url:"updateTurn.php",
        async:true,
        cache:false,
        timeout:10000,
        success:function(data){
            alert(data);
        },
        //this is where AJAX is returning
        error: function(XMLHttpRequest, textStatus, errorThrown){
            alert(textStatus +": "+ errorThrown);
        }
    });//end AJAX
};//end function

The error is caused by the line $player = getCurrentTurn();. If I remove this and echo any string value then it works correctly. This is incredibly basic but I can't seem to see my error. All help appreciated.

EDIT: The AJAX calls error: which results in this alert :

AJAX error message

is the defination of getCurrentTurn() contained in a class in functions.php file? — Sourabh Kumar Sharma
– Sourabh Kumar Sharma, Commented Jun 5, 2015 at 9:34
@Sourabh no, the file simply contains functions only. As far as I can see, there is no need for me to instantiate any objects. — Scott
– Scott, Commented Jun 5, 2015 at 9:37
yes not need if you do not intend to do so, can post what is the response you are getting from your ajax call? — Sourabh Kumar Sharma
– Sourabh Kumar Sharma, Commented Jun 5, 2015 at 9:39
are all the files in the same directory? You're error callback is being fired that points to an http error — Sourabh Kumar Sharma
– Sourabh Kumar Sharma, Commented Jun 5, 2015 at 9:52

Scott · Accepted Answer · 2015-06-05 10:11:56Z

1

Resolved:

Removed include("getConn.php"); from getCurrentTurn() within functions.php and relocated it to be available for the entire file, not just locally available for that function. Therefore, functions.php should be:

include("getConn.php");
...
function getCurrentTurn()
{
$query = $GLOBALS['conn']->prepare("SELECT turn FROM Game");
$query->execute();
$result=$query->fetch(PDO::FETCH_ASSOC);
return $result['turn'];
}
...

answered Jun 5, 2015 at 10:11

Scott

1,9222 gold badges26 silver badges48 bronze badges

Sign up to request clarification or add additional context in comments.

Collectives™ on Stack Overflow

PHP calling function from another file not working

1 Answer 1

Resolved:

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

Resolved:

Comments

Your Answer

Sign up or log in

Post as a guest

Related