$window in angular.js throws exception when using $window.open

Question

I get this error thrown:

Error: Error: [$parse:isecwindow] Referencing the Window in Angular expressions is disallowed!

When I try using $window.open/window.open in angularjs.

Generate.html

<div class="print-report-footer" ng-show="vm.clicked">
    <button type="button" class="btn btn-primary" ng-click="vm.downloadFile('pdf')">PDF</button>
    <button type="button" class="btn btn-primary" ng-click="vm.downloadFile('xls')">XLS</button>
    <button type="button" class="btn btn-primary" ng-click="vm.downloadFile('csv')">CSV</button>
</div>

Generate.ctrl.js

    function downloadFile ( fileType ) {
        var path = '/images/reports/DistrictSchoolReport.' + fileType;
        return $window.open( path );
    }

    self.downloadFile   = downloadFile;

This is the code that I have used. What do I need to do to avoid this error thrown everytime I use $window.open?

can you try $window.open(path); return; Looks like you are calling that function from the view, which is causing the problem. — bamboo_inside
– bamboo_inside, Commented Jun 18, 2015 at 22:55
Are you sure the error is being throwing at $window not elsewhere? You could have scoping issue where this is being initialized as window. — timeiscoffee
– timeiscoffee, Commented Jun 18, 2015 at 22:56
Can you split the code in your question into separate parts identifying which file they're in. At the moment, it doesn't look like your downloadFile function is part of a controller. Seeing as you're using the controller as syntax, it should at least be this.downloadFile = function... — Phil
– Phil, Commented Jun 18, 2015 at 23:23
Plunker demo here ~ plnkr.co/edit/cQdQiPJg0P0Z2wChSNKk?p=preview. It's the return statement — Phil
– Phil, Commented Jun 19, 2015 at 0:25

bamboo_inside · Accepted Answer · 2015-06-18 23:12:21Z

5

You are running $window.open() from the view. Do this instead: (don't use return)

function downloadFile ( fileType ) {
    var path = '/images/reports/DistrictSchoolReport.' + fileType;
    $window.open( path );
}

answered Jun 18, 2015 at 23:12

bamboo_inside

4624 silver badges15 bronze badges

Sign up to request clarification or add additional context in comments.

3 Comments

Phil Over a year ago

It's definitely the return that's causing the error

Monece Solis Over a year ago

@Phil i know this problem is solved, but can you guys explain to me why the return statement causes this error?

bamboo_inside Over a year ago

you were returning the $window.open() function, which was being run from the html template view. Although window is accessible from the document, it's not accessible from the view in this case.

Collectives™ on Stack Overflow

$window in angular.js throws exception when using $window.open

1 Answer 1

3 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

3 Comments

Your Answer

Sign up or log in

Post as a guest

Related