while foreach loop is outputting twice

Question

I want the loop just to output once. Instead it outputs twice. Here is the code:

$results = mysql_query($query);
    while ($c = mysql_fetch_array($results)){
        $individualPostcode = explode(",", $c['postcode']);
        foreach($individualPostcode as $val){ 
            $val = trim($val); //Get rid of spaces
            if($val === $postcode){
                echo $c['url']."<br>";
            }
        }
    }
}

Here is the output:

http://www.dyno.com/home-security/local-experts/greater-london/dyno-locks-and-alarms-enfield
http://www.dyno.com/home-security/local-experts/greater-london/dyno-locks--alarms-enfield
http://www.dyno.com/home-security/local-experts/greater-london/dyno-locks-and-alarms-enfield
http://www.dyno.com/home-security/local-experts/greater-london/dyno-locks--alarms-enfield

I've tried taken out the foreach loop but I need to go through that array checking against a user input.

Here is the initialisation of $postcode:

$userInput = $_POST["input"];
if(strlen($userInput) < 4) 
    echo "User Input : ".$userInput."<br>";
else //Below gets the first three chars of the users string
    echo "User Input : $userInput<br>What is being used : ".mb_substr($userInput, 0, 3)."<br>";

$postcode = mb_substr($userInput, 0, 3);

What is value of $postcode ? And if 2 records have same Comma separated list for post code. Its going to repeat for 2nd record and 1st one ! — Pratik Joshi
– Pratik Joshi, Commented Jun 29, 2015 at 9:26
$postcode is a user input that is formatted so its the first three characters i.e. E10 78P would become E10 — MrHappySandwich
– MrHappySandwich, Commented Jun 29, 2015 at 9:28

Danny Broadbent · Accepted Answer · 2015-06-29 10:01:15Z

1

You can always create an array of the URL's to stop them from duplicating by checking if the url has been put into the array:

$results = mysql_query($query);
$urlsArr = array();
while ($c = mysql_fetch_array($results)){
    $individualPostcode = explode(",", $c['postcode']);
    foreach($individualPostcode as $val){ 
        $val = trim($val); //Get rid of spaces
        if($val === $postcode){
            if (!in_array($c['url'], $urlsArr)) echo $c['url']."<br>";
            $urlsArr[] = $c['url'];
        }
    }
}

answered Jun 29, 2015 at 10:01

Danny Broadbent

1,2091 gold badge10 silver badges21 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

LeDoc · Accepted Answer · 2015-06-29 09:31:37Z

1

mysql_fetch_array returns both an associative and index array for each of your returned results. The foreach loop is going to loop over both and output twice. Try using mysql_fetch_assoc()

http://php.net/manual/en/function.mysql-fetch-array.php

Better still, try moving to the mysqli class. It's faster and mysql is depricated.

http://php.net/manual/en/intro.mysqli.php

answered Jun 29, 2015 at 9:31

LeDoc

9352 gold badges13 silver badges25 bronze badges

1 Comment

MrHappySandwich Over a year ago

I've tried changing the mysql_fetch_array to the mysql_fetch assoc but the output is still the same.

Collectives™ on Stack Overflow

while foreach loop is outputting twice

2 Answers 2

Comments

1 Comment

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

1 Comment

Your Answer

Sign up or log in

Post as a guest

Linked

Related