Using loop in jquery not work

Question

I want to use for loop to create jquery function, but when I add the array parameter in the string, it didn't work. Any suggestion?

var ids=["width_uncheck","thickness_uncheck"];
var names=['width','thickness'];
for(i=0;i<2;i++){
    $("#"+ids[i] ).click(function() {
        $('input:radio[name='+names[i]+']').each(function(i) {
            this.checked = false;
        });
    });
}

For sure your name='+names... needs double quotes should read 'input:radio[name="'+names[i]+'"]') — FirebladeDan
– FirebladeDan, Commented Jul 17, 2015 at 19:33
In the second .each'-loop you use 'i' as index-variable ... use something else. — Ole Sauffaus
– Ole Sauffaus, Commented Jul 17, 2015 at 19:38
The reason is not the quotes. Because I change to 'input:radio[name='+names[0]+']' it works — Alan Yu
– Alan Yu, Commented Jul 17, 2015 at 19:38

charlietfl · Accepted Answer · 2015-07-17 19:53:24Z

1

You can't do this because i has changed to it's maximum at the time the click event occurs.

You need to use a javascript closure which you can easily do with $.each

$.each(ids, function(i, id){
   $("#"+id ).click(function() {
        // no need for `each`, just use `prop()`
        $('input:radio[name='+names[i]+']').prop('checked',false);
    });
});

The difference here is that i is an argument of the function and therefore won't change it's value within the function the way it will in for loop

edited Jul 17, 2015 at 19:53

answered Jul 17, 2015 at 19:36

charlietfl

172k14 gold badges125 silver badges154 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Bhavin Solanki · Accepted Answer · 2015-07-17 19:39:22Z

0

You have error with selector with radio name you need to add quote sign there You need to use $('input:radio[name="'+names[i]+'"]')

For ie

var ids=["width_uncheck","thickness_uncheck"];
var names=['width','thickness'];
for(var i=0;i<2;i++){
    $("#"+ids[i] ).click(function() {
        $('input:radio[name="'+names[i]+'"]').each(function(i) {
            this.checked = false;
        });
    });
}

edited Jul 17, 2015 at 19:39

answered Jul 17, 2015 at 19:37

Bhavin Solanki

4,8143 gold badges28 silver badges47 bronze badges

1 Comment

charlietfl Over a year ago

will still fail due to no closure for i

ijsnow · Accepted Answer · 2015-07-17 19:52:48Z

0

You are missing the quotes for the name in the selector.

You could also just use the jquery each function without an element for your array.

$.each(ids, function (i, value) {
    var ids=["width_uncheck","thickness_uncheck"];
    var names=['width','thickness'];

    $("#"+ids[i] ).click(function() {
        $('input:radio[name="'+names[i]+'"]').each(function(i) {
            this.checked = false;
        });
    });
});

edited Jul 17, 2015 at 19:52

answered Jul 17, 2015 at 19:48

ijsnow

1627 bronze badges

2 Comments

charlietfl Over a year ago

if quotes are a problem (which they aren't), why are they not a problem in your second example?

ijsnow Over a year ago

Sorry, I forgot to add them in there. They are there now. I haven't tested the code as I should have before I answered, that's just what I noticed.

Collectives™ on Stack Overflow

Using loop in jquery not work

3 Answers 3

Comments

1 Comment

2 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

Comments

1 Comment

2 Comments

Your Answer

Sign up or log in

Post as a guest

Related