My first function is having a syntax error

Question

Hello I am just getting into writing functions and I think I am a bit over my head. The javascript console is stating

Uncaught Error: Syntax error, unrecognized expression: "#insert the jsfiddle url"

Since I don't have enough reputation I cannot post two links, but where "insert the jsfiddle url" is the jsfiddles url, it becomes the url of any site I run this code on.

Here is the code is the code for it:

   function menuclick(menuitem, menucontent) {
   $('"#' + menuitem + '"').click(function() {
      $('#cssmenu').hide();
      $('"#' + menucontent + '"').show();
      $('#goback').show();
   })
};


      menuclick(aboutlink, aboutcontainer);

Here is the link to a jsfiddle of it.

Dietz · Accepted Answer · 2015-08-03 08:38:39Z

1

In your code $('"#' + menuitem + '"') is wrong.

When menuitem = "hello", the above code becomes $('"#hello"') which is NOT what you want.

You want $('#' + menuitem) which results in $('#hello') when menuitem = "hello"

Check out this fiddle.

Here is the snippet.

$('#aboutcontainer').hide();
$('#goback').hide();

function menuclick(menuitem, menucontent) {
  $('#' + menuitem).click(function() {
    $('#cssmenu').hide();
    $('#' + menucontent).show();
    $('#goback').show();
  })
};


menuclick('aboutlink', 'aboutcontainer');

<script src="https://ajax.googleapis.com/ajax/libs/jquery/2.1.1/jquery.min.js"></script>
<div id="cssmenu"><a href="#" id="aboutlink">About</a>
</div>
<div id="aboutcontainer">djdsidjkjd
  <br>
  <br>
</div>
<div id="goback">Go back</div>

edited Aug 3, 2015 at 8:38

Dietz

5785 silver badges14 bronze badges

answered Aug 3, 2015 at 7:54

Shrinivas Shukla

4,4632 gold badges23 silver badges35 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

vpt Over a year ago

Thank you so much that makes sense.

Marcos Pérez Gude · Accepted Answer · 2015-08-03 07:54:34Z

1

You have a lot of errors and problems. Here you are your fiddle working:

http://jsfiddle.net/gqwugdf3/2/

What I do:

Remove unnecesary double quotes :

 $('"#' + menuitem + '"') //incorrect
 $('#' + menuitem) // correct

put quotes in calling

  menuclick('aboutlink', 'aboutcontainer');

answered Aug 3, 2015 at 7:54

Marcos Pérez Gude

22.2k4 gold badges41 silver badges70 bronze badges

Collectives™ on Stack Overflow

My first function is having a syntax error

2 Answers 2

1 Comment

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

1 Comment

Comments

Your Answer

Sign up or log in

Post as a guest

Related