angularjs callback / wait for function to finish

Question

I'm i bit stuck with function which is assigned to the $scope variable. need to wait until it's finished.

This is the function assigned to $scope variable:

$scope.ChooseHome = function() {
    ModalWindowService.openChooseHomeDialog($scope);
}

in ModalWindowService I have:

function openChooseHomeDialog($scope) {
    $scope.animationsEnabled = true;

    var modalInstance = $modal.open({
        animation: $scope.animationsEnabled,
        templateUrl: '/view/user/ChooseHomeDialog.html',
        controller: 'chooseHomeDialogController',
        windowClass: 'detail-modal-window'
    });
    modalInstance.result.then(function (CondoID) {
        $scope.choosenCondoID = CondoID;
    });
}

what I want to do is properly receive this variable '$scope.choosenCondoID' after I get it from modal in '$scope.ChooseHome' function and do some work with it.

smth like this options:

$scope.ChooseHome = function() {
    ModalWindowService.openChooseHomeDialog($scope).then(*do my stuff*); /
    ModalWindowService.openChooseHomeDialog($scope).success(*do my stuff*);
}

But it's not working, I'm getting errors like this:

'TypeError: (intermediate value).success is not a function'

As a sidenote...passing on your $scope to a service is a really bad idea. — Bas Slagter
– Bas Slagter, Commented Aug 17, 2015 at 14:36

Bas Slagter · Accepted Answer · 2015-08-17 14:39:20Z

2

Try this:

function openChooseHomeDialog($scope) {
    $scope.animationsEnabled = true;

    return $modal.open({
        animation: $scope.animationsEnabled,
        templateUrl: '/view/user/ChooseHomeDialog.html',
        controller: 'chooseHomeDialogController',
        windowClass: 'detail-modal-window'
    }).result;
}

$scope.ChooseHome = function() {
    ModalWindowService.openChooseHomeDialog($scope).then(*do my stuff*);
}

And...like I commented...passing on the $scope to your service is a bad idea. You should only use $scope in your controller to glue your data to the view. A service just has to do something or return something which you can use.

To complicate it a bit further..you might want to look into the controllerAs syntax as well to be future proof with your code ;)

edited Aug 17, 2015 at 14:39

answered Aug 17, 2015 at 14:37

Bas Slagter

9,9419 gold badges51 silver badges81 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

Pjetr Over a year ago

and don't send your $scope to the service :)

farincz · Accepted Answer · 2015-08-17 14:36:49Z

0

you must return your promise from openChooseHomeDialog function

...
return modalInstance.result.then(function (CondoID) {
  $scope.choosenCondoID = CondoID;
});

answered Aug 17, 2015 at 14:36

farincz

5,1931 gold badge33 silver badges42 bronze badges

Collectives™ on Stack Overflow

angularjs callback / wait for function to finish

2 Answers 2

1 Comment

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

1 Comment

Comments

Your Answer

Sign up or log in

Post as a guest

Related