Splice not removing item from array javascript

Question

I'm having problems with splice in my code, I don't know why is not working, I need to remove the minimum integer from the array.

Here's my code:

var players = [
    "Jug 1",
    "Jug 2",
    "Jug 3",
    "Jug 4"
];

var arrTotal = [72, 71, 70, 75];

function winners(arr) {
    var fstPlace = [], sndPlace= [];
    var min = Math.min.apply(null, arr);
    console.log(min);
    for (var i = 0; i < arr.length; i++) {
        if (arr[i] == min) {
            fstPlace.push(arr.indexOf(min, i));
        }
    }
    if (fstPlace.length == 1) {
        console.log("1st: " + fstPlace);
        arr.splice(min, 1);
        console.log(arr);
    }
    else {
        console.log("Tie: " + fstPlace);
    }
}

winners(arrTotal);

Arun P Johny · Accepted Answer · 2015-08-21 03:56:18Z

1

You have to give the index of the item to be removed

var players = [
  "Jug 1",
  "Jug 2",
  "Jug 3",
  "Jug 4"
];

var arrTotal = [72, 71, 70, 75];

function winners(arr) {
  var fstPlace = [],
    sndPlace = [];
  var min = Math.min.apply(null, arr);
  snippet.log('min: ' + min);

  for (var i = 0; i < arr.length; i++) {
    if (arr[i] == min) {
      fstPlace.push(arr.indexOf(min, i));
    }
  }
  snippet.log('fstPlace: ' + fstPlace)
  if (fstPlace.length == 1) {
    snippet.log("1st: " + fstPlace);
    arr.splice(fstPlace[0], 1);
    snippet.log('result: ' + arr);
  } else {
    snippet.log("Tie: " + fstPlace);
  }
}

winners(arrTotal);

<!-- Provides the `snippet` object, see http://meta.stackexchange.com/a/242144/134069 -->
<script src="http://tjcrowder.github.io/simple-snippets-console/snippet.js"></script>

edited Aug 21, 2015 at 3:56

answered Aug 21, 2015 at 3:53

Arun P Johny

389k68 gold badges532 silver badges532 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

Devsalad Over a year ago

I can't use the value itself?

Devsalad Over a year ago

Thank you Arun, it works perfect. I must wait 6 minutes to accept the answer. :)

Collectives™ on Stack Overflow

Splice not removing item from array javascript

1 Answer 1

2 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

2 Comments

Your Answer

Sign up or log in

Post as a guest

Related