unterminated string literal Javascript

Question

I'm using the following code in php:

PHP:

 $suggested_sentence[0] = "Hello, how are you?";
  echo $suggested_sentence[0] . ' <input type="image" src="button.png" 
  onclick = update_textarea('. $textareacount.','. "'".$suggested_sentence[0]."')/>";

Javascript function:

function update_textarea(count, new_sentence) {
    document.getElementById('sentence' + count).value = new_sentence;
}

But when i press the button i get the error "unterminated string literal but if i change the value of $suggested_sentence[0] = "Hello" it works fine.

What should i do then?

Fenton · Accepted Answer · 2010-07-10 07:33:40Z

1

Check the file after PHP has executed to ensure that your button looks like this...

<input type="image" src="button.png" onclick="update_textarea(1, 'Hello, how are you?');"/>

Note that the onclick event is surrounded with double-quotes.

You can adjust your example like this:

 $suggested_sentence[0] = "Hello, how are you?";
  echo $suggested_sentence[0] . ' <input type="image" src="button.png" 
  onclick="update_textarea('. $textareacount.', '. "'" . $suggested_sentence[0]."'" . ')"/>';

answered Jul 10, 2010 at 7:33

Fenton

253k74 gold badges404 silver badges414 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

Fenton Over a year ago

@fawad, glad I could help. Feel free to click on that tick next to the answer if it solved your problem. Cheers :)

Darin Dimitrov · Accepted Answer · 2010-07-10 07:29:32Z

0

HTML encode $suggested_sentence[0] as it may contain characters that break the javascript literal (such as ' so make sure you set quote_style to ENT_QUOTES for this).

answered Jul 10, 2010 at 7:29

Darin Dimitrov

1.0m277 gold badges3.3k silver badges3k bronze badges

1 Comment

TNi Over a year ago

This is a good suggestion, although not the culprit in this case.

Collectives™ on Stack Overflow

unterminated string literal Javascript

2 Answers 2

1 Comment

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

1 Comment

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related