Passing an array from service to controller

Question

I cannot seem to figure out how to pass an array from service to a controller.

I have a simple service

.service('test', function() {
    var array = []

    return array;
})

And a controller where I call this function when a button is pressed

$scope.testArray = function() {
    $scope.test = test.array;

    console.log("test: ", $scope.test);
};

I get an error test is undefined. Can anyone explain to me please why this doesn't work and how to fix it? I tried storing that array in a separate object but no luck either. THanks

Yes, this is my controller -> .controller('TestCtrl', ['test', function(test) { <- there is a lot more data but I omitted that as I don't think it would be relevant? — lmenus
– lmenus, Commented Sep 5, 2015 at 16:49

Community · Accepted Answer · 2017-05-23 11:44:03Z

2

(See also: this SO question about Angular providers)

A service should put properties directly on this. So instead of

.service('test', function() {
    var array = [];

    return array; 
})

try

.service('test', function() {
    this.array = [];
})

(code style notwithstanding; many would suggest preferring function access over direct object access)

.service('test', function() {
    var array = [];
    this.getArray = function(){
        return array;
    };
})

edited May 23, 2017 at 11:44

CommunityBot

11 silver badge

answered Sep 5, 2015 at 16:53

Hylianpuffball

1,56110 silver badges15 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

lmenus Over a year ago

Thanks a lot! I put it like you showed in the last example and then just tried console.log(test.getArray()); and it works! Can you tell me why wasn't my solution working and this function solved it?

michelem · Accepted Answer · 2015-09-05 16:55:35Z

1

Just change test.arraywith test:

JSFiddle

.controller('youCtrl', ['$scope', 'test', function ($scope, test) {
    $scope.testArray = function() {
       $scope.test = test;

       console.log("test: ", $scope.test);
    };
});

edited Sep 5, 2015 at 16:55

answered Sep 5, 2015 at 16:49

michelem

14.6k5 gold badges55 silver badges67 bronze badges

2 Comments

lmenus Over a year ago

Tried this, doesn't work for me. I might be tripping out already, it is a part of an Ionic app if that might matter.

lmenus Over a year ago

Thanks guys now it works too, this one return object to me and the suggestion above the array so both are good. thanks!

André · Accepted Answer · 2015-09-05 17:10:39Z

0

Add the array variable to your service.

angular.module('moduleName').service('test', function() {
  this.array = [];
});

Inject your service into your controller.

angular.module('moduleName').controller('controllerName', function(test) {
  $scope.test = test.array;

  console.log("test: ", $scope.test);
});

edited Sep 5, 2015 at 17:10

answered Sep 5, 2015 at 17:03

André

1562 silver badges10 bronze badges

Collectives™ on Stack Overflow

Passing an array from service to controller

3 Answers 3

1 Comment

2 Comments

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

1 Comment

2 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related