PHP function help / beginner

Question

Look, if forum post have $hide_smilies is set to 1, I dont want the :p, :o to be replacen with images.

This is how I output forum post bbcode($message);

And Function:

function bbcode($str)
{
    $str = htmlentities($str);

    $find = array(
    "/:p/",
    "/:o/",
    '/\[b](.*?)\[\/b]/is',
    '/\[u](.*?)\[\/u]/is',
    '/\[i](.*?)\[\/i]/is'
    );

    $replace = array(
    '<img src="/images/forum/icon_tongue.gif" alt=":p" border="0" height="15" width="15">',
    '<img src="/images/forum/icon_embarrassed.gif" alt=":o" border="0" height="15" width="15">'
    '<strong>$1</strong>',
    '<u>$1</u>',
    '<i>$1</i>',

    $str = preg_replace($find, $replace, $str);



    return nl2br($str);

Thanks

Edit

function bbcode($str, $hide_smilies = 0)
{

$str = htmlentities($str);

$find = array(
    '/\[b](.*?)\[\/b]/is',
    '/\[u](.*?)\[\/u]/is',
    '/\[i](.*?)\[\/i]/is',
);


$replace = array(
    '<strong>$1</strong>',
    '<u>$1</u>',
    '<i>$1</i>'
);

if ($hide_smilies == 0) 
{
    $find[] = "/:p/";
    $find[] = "/:o/";

    $replace[] = '<img src="/images/forum/icon_tongue.gif" alt=":p" border="0" height="15" width="15">';
    $replace[] = '<img src="/images/forum/icon_embarrassed.gif" alt=":o" border="0" height="15" width="15">';
}

$str = preg_replace($find, $replace, $str);


return nl2br($str);
}

This works but now (if hide_smilies=0) some characters like " gets replaced with " and so on

"This works but now (if hide_smilies=0) some characters like " gets replaced with " and so on" Are you sure this only happens when you hide smilies? You're calling htmlentities() at the very top of the function, that's what it does: php.net/manual/en/function.htmlentities.php — George Marian
– George Marian, Commented Jul 14, 2010 at 3:48
well i did the first time i reloaded, maybe it didnt reload good. but how can you make your output safe then?? if you cant use htmlentities — Basta
– Basta, Commented Jul 14, 2010 at 4:05
I wasn't suggesting that you should not use htmlentities(). Based on that code, there is no reason that it should happen only if hide_smilies=0. It should happen in either case. That problem may be double encoding. That is, it may be that the strings are passed through htmlentities() [or something that has similar functionality] more than once. I would also make sure that there are not issue w/ the HTML source itself. — George Marian
– George Marian, Commented Jul 14, 2010 at 5:06

Jonathan Kuhn · Accepted Answer · 2010-07-14 02:47:48Z

1

if hide smilies is set to 1 then just echo out $message instead of echo'ing out bbcode($message). here is a simple ternary statement that should work:

echo ($hide_smilies==1) ? $message : bbcode($message);

answered Jul 14, 2010 at 2:47

Jonathan Kuhn

15.3k3 gold badges34 silver badges43 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

Faisal Over a year ago

He still needs to do the other replacements though, I think.

Jonathan Kuhn Over a year ago

oh, then pass in a second parameter to the bbcode function that is $hide_smilies, give it a default value of false (or 0). In the function, make two arrays of replacements, one for smilies and one for other. Then do the preg_replace for both arrays. If I had more time I would fix it for you.

Mark Eirich · Accepted Answer · 2010-07-14 02:55:52Z

Just use array_slice() to chop off the unwanted bits. I'm assuming you can pass the $hide_smilies variable to the bbcode() function.

<?php
function bbcode($str, $hide_smilies=0) {
    $str = htmlentities($str);

    $find = array(
    "/:p/",
    "/:o/",
    '/\[b](.*?)\[\/b]/is',
    '/\[u](.*?)\[\/u]/is',
    '/\[i](.*?)\[\/i]/is',
    );

    $replace = array(
    '<img src="/images/forum/icon_tongue.gif" alt=":p" border="0" height="15" width="15">',
    '<img src="/images/forum/icon_embarrassed.gif" alt=":o" border="0" height="15" width="15">',
    '<strong>$1</strong>',
    '<u>$1</u>',
    '<i>$1</i>',
    );

    if ($hide_smilies) {
        $find = array_slice($find, 2);
        $replace = array_slice($replace, 2);
    }

    $str = preg_replace($find, $replace, $str);

    return nl2br($str);
}
?>

Faisal · Accepted Answer · 2010-07-14 02:56:48Z

0

If I'm understanding correctly, you still want to replace [b]'s and [i]'s with their HTML equivalents even if $hide_smilies is 1, right? In that case, initialize each array with only the non-smiley pattenrs and then add the extra elements if $hide_smilies = 1. For example:

// either pass in $hide_smilies, declare it global inside bbcode(),
// or use $_GLOBALS['hide_smilies']
function bbcode($str, $hide_smilies)
{
    $str = htmlentities($str);

    $find = array(
    '/\[b](.*?)\[\/b]/is',
    '/\[u](.*?)\[\/u]/is',
    '/\[i](.*?)\[\/i]/is'
    );

    $replace = array(
    '<strong>$1</strong>',
    '<u>$1</u>',
    '<i>$1</i>');


    if ($hide_smilies == 1)
    {
        $find[] = "/:p/";
        $find[] = "/:o/";

        $replace[] = '<img src="/images/forum/icon_tongue.gif" alt=":p" border="0" height="15" width="15">';
        $replace[] = '<img src="/images/forum/icon_embarrassed.gif" alt=":o" border="0" height="15" width="15">';
    }

    $str = preg_replace($find, $replace, $str);

    return nl2br($str);
}

answered Jul 14, 2010 at 2:56

Faisal

4,6981 gold badge21 silver badges13 bronze badges

3 Comments

Faisal Over a year ago

That probably has to do with you calling htmlentities() at the beginning of your function. If you don't want special characters to be replaced by their html entity equivalents you can comment that out, but watch out for weird characters not getting encoded properly.

Basta Over a year ago

but it didnt get like this before i have always had htmlentities in top. it only got replaced if you look at webpage source. but now all my posts look crazy

Faisal Over a year ago

Well, I corrected some mistakes in your syntax, like not including a closing ")" for your call to array() for $replace. (Compare the two functions side by side and you'll see it.) Was that just a typo when you retyped it, or was that in the original code>?

stormdrain · Accepted Answer · 2010-07-14 02:57:26Z

0

function bbcode($str)
{
    $str = htmlentities($str);

    $find = array(
        '/\[b](.*?)\[\/b]/is',
        '/\[u](.*?)\[\/u]/is',
        '/\[i](.*?)\[\/i]/is'
    );

    $replace = array(
        '<strong>$1</strong>',
        '<u>$1</u>',
        '<i>$1</i>',
     );

    $str = preg_replace($find, $replace, $str);

    return nl2br($str);
}

answered Jul 14, 2010 at 2:57

stormdrain

7,8954 gold badges40 silver badges76 bronze badges

Comments

George Marian · Accepted Answer · 2010-07-14 02:57:43Z

0

Just add a parameter to the function and change the way you build the $find array, accordingly.

function bbcode($str, $hideSmilies = false)
{

$find = array(
'/\[b](.*?)\[\/b]/is',
'/\[u](.*?)\[\/u]/is',
'/\[i](.*?)\[\/i]/is'
);

if (!$hideSmilies)
{
    $find[] = "/:p/";
    $find[] = "/:o/";
}

answered Jul 14, 2010 at 2:57

George Marian

2,66920 silver badges21 bronze badges

2 Comments

Basta Over a year ago

hm it works but now my text characters like " get replaced with " etc

George Marian Over a year ago

@Basta Take my code and work it into your function. Replace the section where you create $find in your code with what I have and add my if statement below that. And, of course, replace the function line with what I have. Sorry, I should've mentioned that it isn't the complete code in my post.

Collectives™ on Stack Overflow

PHP function help / beginner

Edit

5 Answers 5

2 Comments

Comments

3 Comments

Comments

2 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

Edit

5 Answers 5

2 Comments

Comments

3 Comments

Comments

2 Comments

Your Answer

Sign up or log in

Post as a guest

Related