Problems with javascript inside echo

Question

I want to echo the following code:

<a href="http://delicious.com/save" onclick="window.open('http://delicious.com/save?v=5&noui&jump=close&url='+encodeURIComponent(location.href)+'&title='+encodeURIComponent(document.title), 'delicious','toolbar=no,width=550,height=550'); return false;" class="delicious" target="_blank">Add to Delicious</a>

The problem is that Dreamweaver warns me on syntax errors I can not figure out. Who can spot the syntax errors? The html and script on its own works just fine - the problem comes with the php when it is echoed.

are you trying to echo it with php e.g echo 'a href=""etc'; ? if so you will need to escape any single or double quotes depending on what you enclose your string in. e.g echo "<a href=\"delicious.com/save\""; etc — Luke
– Luke, Commented Jul 16, 2010 at 11:44

ahmet2106 · Accepted Answer · 2010-07-16 11:53:29Z

1

you can use:

<?php
echo '<a href="http://delicious.com/save" onclick="window.open(\'http://delicious.com/save?v=5&noui&jump=close&url=\'+encodeURIComponent(location.href)+\'&title=\'+encodeURIComponent(document.title), \'delicious\',\'toolbar=no,width=550,height=550\'); return false;" class="delicious" target="_blank">Add to Delicious</a>';
?>

not tested, but should work.

answered Jul 16, 2010 at 11:53

ahmet2106

5,0174 gold badges29 silver badges41 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Markus Hedlund · Accepted Answer · 2010-07-16 11:36:48Z

1

You shouldn't have & in HTML, these should be encoded to &.

<a href="http://delicious.com/save" onclick="window.open('http://delicious.com/save?v=5&amp;noui&amp;jump=close&amp;url='+encodeURIComponent(location.href)+'&amp;title='+encodeURIComponent(document.title), 'delicious','toolbar=no,width=550,height=550'); return false;" class="delicious" target="_blank">Add to Delicious</a>

That's the only error I can spot.

answered Jul 16, 2010 at 11:36

Markus Hedlund

24.4k22 gold badges82 silver badges113 bronze badges

Comments

Toto · Accepted Answer · 2010-07-16 12:54:21Z

0

You have to escape " chars :

echo "<a href=\"http://delicious.com/save\" onclick=\"window.open('http://delicious.com/save?v=5&noui&jump=close&url='+encodeURIComponent(location.href)+'&title='+encodeURIComponent(document.title), 'delicious','toolbar=no,width=550,height=550'); return false;\" class=\"delicious\" target=\"_blank\">Add to Delicious</a>";

As bluesmoon said it's better written as :

echo <<<ENDOFECHO
<a href="http://delicious.com/save" onclick="window.open('http://delicious.com/save?v=5&noui&jump=close&url='+encodeURIComponent(location.href)+'&title='+encodeURIComponent(document.title), 'delicious','toolbar=no,width=550,height=550'); return false;" class="delicious" target="_blank">Add to Delicious</a>";
ENDOFECHO;

edited Jul 16, 2010 at 12:54

answered Jul 16, 2010 at 12:03

Toto

91.7k63 gold badges97 silver badges135 bronze badges

1 Comment

bluesmoon Over a year ago

a HEREDOC would be better in this case

Collectives™ on Stack Overflow

Problems with javascript inside echo

3 Answers 3

Comments

Comments

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

Comments

Comments

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related