ASP.NET MVC DropDownList not setting selected value

Question

Consider the following model:

public class TagType
{
    public int Id { get; set; }
    public string Description { get; set; }
}

public class Tag
{
    public int Id { get; set; }
    public string Description { get; set; }
    public TagType TagType { get; set; }

    public DropDownListViewModel TagTypeViewModel { get; set; }
    public int TagTypeId { get; set; }
}

I have the following Action in a controller:

public ActionResult Edit(int id)
{
    // Load from database
    IEnumerable<TagType> tagTypes = TagTypeDal.GetAll().ToList();
    Tag tag = TagDal.Get(id);

    tag.TagTypeViewModel = new DropDownListViewModel();

    tag.TagTypeViewModel.Items = new List<SelectListItem>();
    tag.TagTypeViewModel.Items.Add(new SelectListItem { Text = "None", Value = "-1" });
    tag.TagTypeViewModel.Items.AddRange(tagTypes
                                        .Select(tt => new SelectListItem 
                                                { 
                                                    Text = tt.Description, 
                                                    Value = tt.Id.ToString(), 
                                                    Selected = tt.Id == tag.TagType.Id 
                                                }).ToList());

    return View(tag);
}

The select list has one element that has Selected=true, and it's not the first element. And on my Edit.cshtml I have:

@model Models.Tag

@Html.DropDownListFor(model => model.TagTypeId,
                      @Model.TagTypeViewModel.Items,
                      new { @class = "form-control" })

My problem is that the generated drop down never selects the element that has Selected=true, it always shows the first element.

Am I calling the wrong overload for DropDownListFor? Or am I building the select list wrong? Or is it somethig else?

The Selected property of SelectListItem is ignored when binding to a property in your model. Its the value of the property which determines what is selected. Set the value of TagTypeId to a value which matches one of your options and it will be selected — user3559349
– user3559349, Commented Sep 22, 2015 at 9:49

Josh Crozier · Accepted Answer · 2015-12-10 03:23:53Z

1

You should fill model.TagTypeId with selected TagTypeId in your Controller.

DropDownListFor selected value depends on first parameter value.

edited Dec 10, 2015 at 3:23

Josh Crozier

242k56 gold badges401 silver badges316 bronze badges

answered Sep 22, 2015 at 9:48

teo van kot

12.5k10 gold badges41 silver badges73 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

Bsa0 Over a year ago

Yes, that was it. So that means the Selected property of the SelectListItem does nothing at all when binding to a property...

Collectives™ on Stack Overflow

ASP.NET MVC DropDownList not setting selected value

1 Answer 1

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related