Function call into other function with js object

Question

I have two functions one and two, where function one calls in second function but it doesn't work,

for example:

function one() {
 var a = 1;
 var position = {
  global: function(b) {
    console.log(b);
  }
 }
}

function two(){
 $(window).on('swipedown', function() {
   one();
   position.global(a);
});
}

two();

demo`

jsfiddle

You need to declare both a and position in a shared scope — Arun P Johny
– Arun P Johny, Commented Oct 6, 2015 at 9:36
Other way would be to make your function returning relevant variables if you don't want to pollute the outer scope — A. Wolff
– A. Wolff, Commented Oct 6, 2015 at 9:42

user1399844 · Accepted Answer · 2015-10-06 09:40:02Z

1

You need to declare the a and position object outside the function to avoid closure.

var a = null, position = {};

function one() {
  a = 1;
  position = {
  global: function(b) {
    console.log(b);
  }
 }
}

function two(){
 $(window).on('swipedown', function() {
   one();
   position.global(a);
});
}

two();

answered Oct 6, 2015 at 9:40

user1399844

Sign up to request clarification or add additional context in comments.

Comments

Arun P Johny · Accepted Answer · 2015-10-06 09:39:52Z

The problem here is the scope of the variables a and position, since you have declared them in the function one, it exists only inside that function, once the function is exited the variables are no longer available.

Since you are accessing the variables in function two, you need to declare them in a shared scope like

var position, a;

function one() {
  a = 1;
  position = {
    global: function(b) {
      snippet.log('b:' + b);
    }
  }
}

function two() {
  $(window).on('scroll', function() {
    one();
    position.global(a);
  });
}

two();

body {
  height: 3000px;
}

<script src="https://ajax.googleapis.com/ajax/libs/jquery/2.1.1/jquery.min.js"></script>
<!-- Provides the `snippet` object, see http://meta.stackexchange.com/a/242144/134069 -->
<script src="http://tjcrowder.github.io/simple-snippets-console/snippet.js"></script>

Another way to use the variable a is to make use of closure like

var position;

function one() {
  var a = 1;
  position = {
    global: function() {
      snippet.log('a:' + a);
    }
  }
}

function two() {
  $(window).on('scroll', function() {
    one();
    position.global();
  });
}

two();

body {
  height: 3000px;
}

<script src="https://ajax.googleapis.com/ajax/libs/jquery/2.1.1/jquery.min.js"></script>
<!-- Provides the `snippet` object, see http://meta.stackexchange.com/a/242144/134069 -->
<script src="http://tjcrowder.github.io/simple-snippets-console/snippet.js"></script>

Collectives™ on Stack Overflow

Function call into other function with js object

2 Answers 2

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related