angular.js factory variable

Question

I have this factory:

app.factory('user', function($http) {
    var state; // logged state

    function login(data) {
        $http.post('/login', {..}).success(function(data) {
            this.state = 1;

        });
        console.log(this.state); // undefined
        return this.state;
    }

    return {
        login: login
    }
});

When I try to use it inside a controller:

app.controller('TestCtrl', function(user) {
    this.login = function() {
        alert(user.login(this.data)); // undefined
    };
});

What am I doing wrong? I've got same code in other project and it's working there.

Michel · Accepted Answer · 2015-10-11 18:52:59Z

1

this in the success callback does not refer to the service. That's why you got an undefined, besides the fact that the console.log is outside the callback.

You should have better results if you cache this at the beginning of the service:

var service = this;

And in the callback, store state in service:

service.state = 1;

edited Oct 11, 2015 at 18:52

answered Oct 11, 2015 at 18:41

Michel

28.6k6 gold badges67 silver badges72 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

dontHaveName Over a year ago

tried, but also not working because I should use promises

Michel Over a year ago

Indeed, login should return the $http promise, and you could process the api response in user.login(..).then(...). The purpose of my answer was to alert you on the this problem.

Collectives™ on Stack Overflow

angular.js factory variable

1 Answer 1

2 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

2 Comments

Your Answer

Sign up or log in

Post as a guest

Related