Jquery Checkbox Check and Uncheck not working well

Question

I have the following script that is supposed to check and uncheck the following html form based on the user name that has been picked from the dropdown :

<div>
    <select name="user_name" id="user_name" class="user_name form-control">
        <option>Please select : </option>
        <?php foreach ($system_users as $value) {
            ?>
            <option value="<?php echo $value['id']; ?>"><?php echo $value['user_name']; ?></option>
            <?php
        }
        ?>
    </select>
</div>

<?php foreach ($reports_functions as $value) {
    ?>
    <input type="checkbox" name="functions[]" id="functions" value="<?php echo $value['id']; ?>"  class="form-control functions reports_functions" /> <?php echo $value['name']; ?>
    <hr>
    <br />

    <?php
}
?>

The following is my jquery script :

$("#user_name").change(function () {
    var user_id = this.value;
    $.ajax({
        type: "GET",
        url: "<?php echo base_url(); ?>admin/get_user_permissions/" + user_id,
        dataType: "JSON",
        success: function (response) {
             $("input:checkbox").attr("checked", false);

            for (i = 0; i < response.length; i++) {
                var value = response[i].function_id;
                $("input:checkbox[value=" + value + "]").attr("checked", true);
            }
        }
    });
});

The problem I'm having is when I select a username , the check box are not checked because of the line : $("input:checkbox").attr("checked", false); but when I remove it , it checks them but does not remove the previously checked checkboxes. How can I solve this issue?

use .prop("checked",true) instead of .attr(..

Rajaprabhu Aravindasamy
– Rajaprabhu Aravindasamy

2015-10-22 11:50:46 +00:00
Commented Oct 22, 2015 at 11:50 — Rajaprabhu Aravindasamy
– Rajaprabhu Aravindasamy, Commented Oct 22, 2015 at 11:50

Praveen Kumar Purushothaman · Accepted Answer · 2015-10-22 12:03:00Z

2

You have to use prop() instead of attr(). Change the code to:

$("input:checkbox[value=" + value + "]").prop("checked", true);

answered Oct 22, 2015 at 12:03

Praveen Kumar Purushothaman

167k27 gold badges215 silver badges261 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

Praveen Kumar Purushothaman Over a year ago

If you have a look at this: jQuery Blog, which says the release of new jQuery 1.6.1, they have changed the way .attr() handles boolean values.

Suresh Atta Over a year ago

Okay. Now making sense. Always care to explain the reason for changes in OP codes. That makes a lot sense. Mere code is not an answer.

user5105916 · Accepted Answer · 2015-10-22 12:02:34Z

1

Use prop instead of attr. Change the code to:

$("input:checkbox[value=" + value + "]").prop("checked", true);

answered Oct 22, 2015 at 12:02

user5105916

Collectives™ on Stack Overflow

Jquery Checkbox Check and Uncheck not working well

2 Answers 2

2 Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

2 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related