need to check all items in string array with if condition

Question

i have got the below code to check whether the login user access to menu item

but if first item fails the if condition it is redirecting to error page, but i need to check second item from that string array with if condition even the first item fails the if condition ...

please find the below given code for test..

var count = 0;
string[] strPageId = PageId.Split(';');


foreach (string menuPageId in strPageId)
{
       if (objDALookup.IsPageVisible(PageType,Int32.Parse(menuPageId), role, AcctId) == false)
       {
           Session["ErrorInfo"] = "Access denied, please contact system administrator.";
           new Lib.Utils.Log().logInfo("FORCE_ACCESS", strUser + " tried to access PageId:" + PageId + " PageType:" + PageType);
           Response.Redirect(ConfigurationManager.AppSettings["ACCESS_DENIED_URL"], true);
       }
       else
       {
            count++;
            if (count == strPageId.Length) break;

       }
 }

So do you want to check all items or just next item in the list after the failing one? — krivtom
– krivtom, Commented Jan 28, 2016 at 5:06

Adil · Accepted Answer · 2016-01-28 05:24:10Z

2

You can make condition something like this by figuring out condition in loop and executing the action outside loop once it is decided.

bool access = false;
foreach (string menuPageId in strPageId)
{    
   if (objDALookup.IsPageVisible(PageType,Int32.Parse(menuPageId), role, AcctId) == true)
   {
        access = true; 
        break;
   }
}

if(!access)
{

    Session["ErrorInfo"] = "Access denied, please contact system administrator.";
           new Lib.Utils.Log().logInfo("FORCE_ACCESS", strUser + " tried to access PageId:" + PageId + " PageType:" + PageType);

     Response.Redirect(ConfigurationManager.AppSettings["ACCESS_DENIED_URL"], true);
}

OR

You can use linq

bool access = strPageId.Any(s=> objDALookup.IsPageVisible(PageType,Int32.Parse(menuPageId), role, AcctId) == true);

if(!access)
{

}

edited Jan 28, 2016 at 5:24

answered Jan 28, 2016 at 5:06

Adil

148k25 gold badges217 silver badges207 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

Adil Over a year ago

Putting not with access bool result would do when access is not to any of tab.

Collectives™ on Stack Overflow

need to check all items in string array with if condition

1 Answer 1

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related