Iterating multiple variables in ForEach

Question

Using the below code I'm trying to find servers that have mismatching power status in our SQL database (manually entered, so prone to mistakes) and vCenter. I doesn't quite work though since at -And $VM.PowerState -like "PoweredOn" it gets the status of all servers (about 500) rather than just one server at a time, causing the statement to always fail.

# $VM = List of Virtual Machines, properties Name and PowerState
# $ServerList = List of Servers, properties Name and Status.

foreach ($serverEntry in $ServerList) {
    if ($VM.Name -contains $serverEntry.Name -And $VM.PowerState -like "PoweredOn" -And $serverEntry.Status -like "In Use") {
        Stuff will happen
    } else {
        Some other stuff
    }
 }

I tried a nested loop but can't get that to work, and since the servers aren't listed in the same order I can't use a simple counter ($i).

How do I solve this?

Ansgar Wiechers · Accepted Answer · 2016-03-02 13:55:34Z

1

Put the elements of the list $VM in a hashtable:

$vmlist = @{}
$VM | ForEach-Object { $vmlist[$_.Name] = $_ }

That gives you a data structure where you can access your VM objects by the name of the VM. Use that in the $ServerList loop:

foreach ($serverEntry in $ServerList) {
    if ($vmlist[$serverEntry.Name].PowerState -eq 'PoweredOn' -and $serverEntry.Status -eq 'In Use') {
        # do some
    } else {
        # do other
    }
}

answered Mar 2, 2016 at 13:55

Ansgar Wiechers

202k27 gold badges286 silver badges363 bronze badges

Sign up to request clarification or add additional context in comments.

9 Comments

Notumlord Over a year ago

Almost but not quite. In Use is getting matched/true with both PoweredOn and PoweredOff.The only time it´s not matched and goes to the else part is when the the Status is something other then In Use (for example 'removed' or 'waiting for removal'

Ansgar Wiechers Over a year ago

I doubt that. Please provide evidence.

Ansgar Wiechers Over a year ago

Show your modified code. Show sample input data. Show the generated output.

Notumlord Over a year ago

imgur.com/a/lbdq9 Here is sample output, the PS is the output from your code and the Excel is a refrence list i created earlier pastebin.com/CpUpvPU0 Here is my updated code

Notumlord Over a year ago

The excel list can also be considerd the input data since its a export-csv result of my $Table and $VMList variables

|

Martin · Accepted Answer · 2016-03-02 13:53:59Z

0

foreach ($serverEntry in $ServerList)
{
    $currentVM = $VM | ? {$_.Name -eq $serverEntry.Name}
    if ($currentVM.PowerState -like "PoweredOn" -And $serverEntry.Status -like "In Use") {Stuff will happen} else {Some other stuff}

 }

answered Mar 2, 2016 at 13:53

Martin

1,9933 gold badges17 silver badges23 bronze badges

Collectives™ on Stack Overflow

Iterating multiple variables in ForEach

2 Answers 2

9 Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

9 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related