android: how to add item to an array list

Question

I want to add all item from photo's folder to arraylist and below is my code -

here is my model

public class Model {
    private String image;

    public String getImage() {
        return image;
    }

    public void setImage(String image) {
        this.image = image;
    }
}

here is my activity

public class MainActivity extends Activity {

    private Model model;
    private ArrayList<Model> alPhoto;
    private File file;

    @Override
    protected void onCreate(Bundle savedInstanceState) {
        super.onCreate(savedInstanceState);
        setContentView(R.layout.activity_main);

        alPhoto = new ArrayList<Model>();
        String root_sd = Environment.getExternalStorageDirectory().toString();
        file = new File(root_sd + "/photo/");
        File list[] = file.listFiles();

        for (int i = 0; i < list.length; i++) {

    //      alPhoto.add(list[i].getName());

            model = new Model();
            model.setImage(alPhoto.get(i).getImage());
            alPhoto.add(model);

            Log.e("Load image from sd card******* :    ", "Loading...." + alPhoto.get(i));
        }
    }
}

i am unable to set image to arraylist as showing array index outof bound. — Mohd Sakib Syed
– Mohd Sakib Syed, Commented Mar 10, 2016 at 9:57

Mohd Sakib Syed · Accepted Answer · 2016-03-10 11:00:39Z

1

Finally I got the solution.

for (int i = 0; i < list.length; i++) 
{
        String strPath = list[i].getAbsolutePath();
        Log.e("Checking path",">>"+strPath);

        Model model = new Model();
        model.setImage(strPath);
        alPhoto.add(model);

        Log.e("Checking arraylist",">>"+alPhoto);
}

answered Mar 10, 2016 at 11:00

Mohd Sakib Syed

1,7991 gold badge26 silver badges45 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Ajinkya · Accepted Answer · 2016-03-10 09:59:10Z

0

The problem is in your for a loop. You declare model globally so which is added only the last item in list is your problem instead of declare locally in for loop

for (int i = 0; i < list.length; i++) {
// alPhoto.add(list[i].getName());

        Model model = new Model();
        model.setImage(alPhoto.get(i).getImage());
        alPhoto.add(model);


        Log.e("Load image from sd card******* :    ", "Loading...." + alPhoto.get(i));

    }

answered Mar 10, 2016 at 9:59

Ajinkya

1,0497 silver badges15 bronze badges

2 Comments

Mohd Sakib Syed Over a year ago

Thanks for the answer but still showing error like this. Unable to start activity ComponentInfo{com.example.android.demogridview/com.example.android.demogridview.MainActivity}: java.lang.IndexOutOfBoundsException: Invalid index 0, size is 0

Ajinkya Over a year ago

Before for loop check with condition list.length>0

Collectives™ on Stack Overflow

android: how to add item to an array list

2 Answers 2

Comments

2 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

2 Comments

Your Answer

Sign up or log in

Post as a guest

Related