Angular $resource then not returning data

Question

I have this simple app witha factory and a controller:

angular.module('AppName', ['ngResource'])

.factory('apiData', ['$resource', function ($resource) {
    var apiRequest = $resource("https://live.reddcoin.com/api/addr/:address/balance");
    return {
        full: function(address){
            return apiRequest.get({address: address}).$promise
            .then(
                function(data){ console.log(data); return data;},
                function(){ return 'error'; }
            );
        }
        }
}])

.controller('TwoController', function($scope, apiData){
    $scope.price = apiData.full('RszZrK51ur5G67y3Wy6niTnawdYYdBRZEq').then(function(data){console.log(data); return data;});
});

The then sections in both factory and controller not returning data from the api resource. Instead it returns e { $promise=Promise, $resolved=true, toJSON=function(), more...} as can be seen in the console.

The url from the example api resource: https://live.reddcoin.com/api/addr/RszZrK51ur5G67y3Wy6niTnawdYYdBRZEq/balance

And the example on jsfiddle

Pankaj Parkar · Accepted Answer · 2016-04-14 10:34:28Z

2

I'm not sure why $resource doesn't include data(not in object format) inside object return by promise, It display result like below

e {$promise: Promise, $resolved: true} // 1003021043401956 isn't included there

I think get request is expecting object returned from the server. So if it doesn't return an object, then it will not include the same in response

There are 2 ways to solve this problem.

Do return data in object format like {'data': '1003021043401956'}

Create your own get request object inside resource, that will modify before it returns promise object.

var apiRequest = $resource("https://live.reddcoin.com/api/addr/:address/balance", {}, {
   get: {
      method: 'GET',
      transformResponse: function(response){
         return {data: response}; //creating object
      }
   }
});

Fiddle

answered Apr 14, 2016 at 10:34

Pankaj Parkar

136k23 gold badges241 silver badges307 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

fikkatra · Accepted Answer · 2016-04-14 10:04:52Z

1

Try this:

.controller('TwoController', function($scope, apiData){
    apiData.full('RszZrK51ur5G67y3Wy6niTnawdYYdBRZEq').then(function(data){
        console.log(data); 
        $scope.price = data;
    });
});

Remember that promises are chained. So eventhough you return data in the success callback, the result of then is still a promise (with data as the inner result).

Working code snippet:

angular.module('AppName', ['ngResource'])

.factory('apiData', ['$resource', function ($resource) {
    var apiRequest = $resource("https://live.reddcoin.com/api/addr/:address/balance");
    return {
        full: function(address){
            return apiRequest.get({address: address}).$promise
            .then(
                function(data){ console.log(data); return data;},
                function(){ return 'error'; }
            );
        }
        }
}])

.controller('TwoController', function($scope, apiData){
    apiData.full('RszZrK51ur5G67y3Wy6niTnawdYYdBRZEq').then(function(data){console.log(data); $scope.price =  data;});
});

<script src="https://ajax.googleapis.com/ajax/libs/angularjs/1.2.23/angular.min.js"></script>
<script src="https://code.angularjs.org/1.2.23/angular-resource.min.js"></script>
<div ng-app="AppName" ng-controller="TwoController">{{price}}</div>

edited Apr 14, 2016 at 10:04

answered Apr 14, 2016 at 9:59

fikkatra

5,9024 gold badges45 silver badges74 bronze badges

4 Comments

neptune Over a year ago

Yes, but data should be the returned data from the resolved promise, isn't it?

fikkatra Over a year ago

exactly, but you cannot return data within the 'then' success callback, and assign the result of 'then' to the scope. The result of 'then' is always a promise. The only way to assign the data itself to the scope, is to assign the scope variable within the then success callback.

neptune Over a year ago

Got it, but console.log(data); in the success callback still don't show me in the console the data I need. That's what I don't understand.

Pankaj Parkar Over a year ago

@fikkatra you know, even if OP do this $scope.price = apiData.full('RszZrK51ur5G67y3Wy6niTnawdYYdBRZEq') should work Ideally.. There is no need to have .then to wait till data comes up..

Collectives™ on Stack Overflow

Angular $resource then not returning data

2 Answers 2

Comments

4 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

4 Comments

Your Answer

Sign up or log in

Post as a guest

Related