standard / readable array declaration and using

Question

what in your opinion more standard / readable / efficient code of array declaration :

one way :

$days = array(1=>'Sun', 'Mon', 'Tue', 'Wed', 'Thu', 'Fri', 'Sat');

then use : $days[$value]

or the second way :

$days = array('Sun', 'Mon', 'Tue', 'Wed', 'Thu', 'Fri', 'Sat');

then use : $days[$value-1]

update : i cant sure that the values be in [0-6] , because that i dont offer 3 way.

I'd go with the zero-based (2nd) in order to comply directly with the internal PHP representation (e.g., date('w')). Also, note the ISO-8601 numeric representation (N). — jensgram
– jensgram, Commented Sep 13, 2010 at 13:04
@jensgram: and what happens when the array has nothing to do with weekdays? ;) — fabrik
– fabrik, Commented Sep 13, 2010 at 13:06
@Shrapnel: Nobody said we must stick with this example. At least OP didn't. — fabrik
– fabrik, Commented Sep 13, 2010 at 13:19
@fabrik In general I would index my array corresponding to whatever I'm looking up. Thus, alternative 1 in general, which translates directly to alternative 2 when the data is (or ought to be) zero-based. Also, I'd judge by overall readability, not +/- 1 CPU cycle. — jensgram
– jensgram, Commented Sep 13, 2010 at 13:25

codaddict · Accepted Answer · 2010-09-13 13:04:29Z

3

How about the 3rd way:

$days = array('Sun', 'Mon', 'Tue', 'Wed', 'Thu', 'Fri', 'Sat');

and access it as:

$days[$value]

by ensuring that $value has value between [0,6]

answered Sep 13, 2010 at 13:04

codaddict

457k83 gold badges502 silver badges537 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

fabrik Over a year ago

This will apply only when we stick with this example.

Haim Evgi Over a year ago

i cant its came from db query that Not up to me

Your Common Sense · Accepted Answer · 2010-09-13 13:06:39Z

2

a funny one:

$days = array('Zer','Sun', 'Mon', 'Tue', 'Wed', 'Thu', 'Fri', 'Sat');

(a friend of mine used a month name "Nulleary" once)
but seriously, it depends on where this array does come from.
For this particular example it should be just date("D",$tstamp);

though the whole problem negligible to me.
I am often using just

$days = explode(" ",'Sun Mon Tue Wed Thu Fri Sat');

and find it very handy.

answered Sep 13, 2010 at 13:06

Your Common Sense

158k42 gold badges226 silver badges374 bronze badges

2 Comments

fabrik Over a year ago

@stereofrog: Thanks, that was funny. It's interesting how lazy programmers lives here.

Your Common Sense Over a year ago

@stereofrog whoops! yu're right. Gonna check my server right now - it must be burning of such overload! :)

fabrik · Accepted Answer · 2010-09-13 14:23:08Z

1

Definitely the first one (when keys are correctly defined).

In the second one you need to do a minus (extract) this ~~is an unnecessary cpu cycle~~ makes your code less readable and less maintenable.

Edit: I hope all of you lazy programmers are happy out there.

edited Sep 13, 2010 at 14:23

answered Sep 13, 2010 at 13:04

fabrik

14.4k8 gold badges58 silver badges71 bronze badges

3 Comments

Your Common Sense Over a year ago

OH My Holy God! A whole CPU cycle! A disaster indeed.

Your Common Sense Over a year ago

Yeah and Achilles will never overtake Tortoise

fabrik Over a year ago

Sorry, i'm definitely not a fan of dialogues like this.

Collectives™ on Stack Overflow

standard / readable array declaration and using

3 Answers 3

2 Comments

2 Comments

3 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

2 Comments

2 Comments

3 Comments

Your Answer

Sign up or log in

Post as a guest

Related