JavaScript eval() JSON issue

Question

I have the JSON string below :

{ "name":"Ruby on Rails Baseball Jersey", "price":"19.99",
"id":"1025786064",
"image":"http://127.0.0.1:3001/assets/products/4/product/ror_baseball.jpeg" }, { "name":"Ruby on Rails Baseball Jersey", "price":"19.99",
"id":"1025786064",
"image":"http://127.0.0.1:3001/assets/products/5/product/ror_baseball_back.jpeg" }, { "name":"Ruby on Rails Ringer T-Shirt", "price":"19.99",
"id":"187438981",
"image":"http://127.0.0.1:3001/assets/products/9/product/ror_ringer.jpeg" }, { "name":"Ruby on Rails Ringer T-Shirt", "price":"19.99",
"id":"187438981",
"image":"http://127.0.0.1:3001/assets/products/10/product/ror_ringer_back.jpeg" }, { "name":"Apache Baseball Jersey", "price":"19.99",
"id":"706676762",
"image":"http://127.0.0.1:3001/assets/products/1004/product/apache_baseball.png" }, { "name":"Ruby Baseball Jersey", "price":"19.99", "id":"569012001", "image":"http://127.0.0.1:3001/assets/products/1008/product/ruby_baseball.png" }

Then in jQuery:

var d = eval("(" + data + ")"); //data is the json string above.

$.each(d, function(idx, item) {
 alert(item);      
});

There is no error, but it only shows the first sequence's data. How can I loop through all the data?

Thank you.

Piotr Rochala · Accepted Answer · 2010-09-14 10:40:53Z

1

Firstly, make sure you use JSON parser from here: https://github.com/douglascrockford/JSON-js/blob/master/json2.js

then your code will look somewhat like this:

var myArrayOfObjects = JSON.parse("[" + data + "]");
for (obj in myArrayOfObjects)
{
   alert("Name:" + myArrayOfObjects[obj].name);
}

or in Jquery:

$.each(myArrayOfObjects , function(i, o) {
 alert("Name:" + o.name);      
});

answered Sep 14, 2010 at 10:40

Piotr Rochala

7,8022 gold badges36 silver badges54 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

Cheung Over a year ago

You are right! i should use "[" + data + "]" instead of "(" + data + ")".

Delan Azabani · Accepted Answer · 2010-09-14 10:23:11Z

1

Using eval() to parse JSON is unsafe. Try using the browser-native (no libraries needed!) function JSON.parse() instead, which is implemented across all browsers and is secure.

answered Sep 14, 2010 at 10:23

Delan Azabani

81.8k30 gold badges174 silver badges215 bronze badges

2 Comments

David Hedlund Over a year ago

It's not implemented across all browsers. It's not even implemented in IE 8.

Piotr Rochala Over a year ago

You are wrong. Native JSON support has been added in EcmaScript 3.1. Thus IE6 and IE7 and older versions of Firefox don't support it.

Q2Ftb3k · Accepted Answer · 2010-09-14 10:24:53Z

1

Crockford advises against using eval to parse JSON, so you should be using the JSON.parse function.

Here is where you would use it:

http://www.json.org/js.html

answered Sep 14, 2010 at 10:24

Q2Ftb3k

6883 gold badges10 silver badges18 bronze badges

Comments

adamk · Accepted Answer · 2010-09-14 10:25:22Z

1

Try:

var d = eval("[" + data + "]");

JSON arrays are wrapped in square brackets, e.g.: '[ 1,2,3 ]'

(Yes, and don't use eval but the JSON built-in object or similar, safer solutions)

answered Sep 14, 2010 at 10:25

adamk

47.1k7 gold badges52 silver badges57 bronze badges

2 Comments

Delan Azabani Over a year ago

That would return an array with one member, the JSON content. To avoid that, we use plain old parentheses, which doesn't add any wrapping of any sorts, but rather just prevents syntax errors.

adamk Over a year ago

@Delan - No, look at the OP's sample string, it's a comma separated list.

hydrogen · Accepted Answer · 2010-09-14 10:25:25Z

1

Try wrapping your JSON with [ ]

You can validate your JSON here: JSONLint Validator to get some sense as to where the problem lies.

answered Sep 14, 2010 at 10:25

hydrogen

2,87622 silver badges20 bronze badges

Collectives™ on Stack Overflow

JavaScript eval() JSON issue

5 Answers 5

1 Comment

2 Comments

Comments

2 Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

5 Answers 5

1 Comment

2 Comments

Comments

2 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related