JS Function not working

Question

I am currently working on a school project and one of my functions is not running, onclick. I dont know why. I know its the function because i added a console.log() command.

HTML:

<div id="popup">
        <div id="contain">
            <div id="advert"><a href="#" onclick="close()" id="close">close</a></div>
        </div>
        <div id="block"></div>
        </div>

JS:

function close(){
                console.log("worked");
                $("#popup").hide();
            };

close() as a global is already taken by the browser. Try renaming the function to closePopup() or similar to avoid the conflict. — Jonathan Lonowski
– Jonathan Lonowski, Commented May 29, 2016 at 5:02
This is one reason why you shouldn't use inline event handlers in global scope. — T J
– T J, Commented May 29, 2016 at 5:09

Imesha Sudasingha · Accepted Answer · 2016-05-29 05:05:23Z

3

function closePopup(){
  console.log("worked");
  $("#popup").hide();
};

<script src="https://ajax.googleapis.com/ajax/libs/jquery/2.1.1/jquery.min.js"></script>
<div id="popup">
        <div id="contain">
            <div id="advert"><a href="#" onclick="closePopup()" id="close">close</a></div>
        </div>
        <div id="block"></div>
</div>

Your code didn't work because, close is an inbuilt function. Changing the name of the function do the trick.

answered May 29, 2016 at 5:05

Imesha Sudasingha

3,5801 gold badge29 silver badges38 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

divinemaniac · Accepted Answer · 2016-05-29 05:08:01Z

0

You named your function close, which is reserved for window.close() and that is why it is not working. Just name it to something else and it will work :D cheers!

answered May 29, 2016 at 5:08

divinemaniac

2771 silver badge9 bronze badges

Collectives™ on Stack Overflow

JS Function not working

2 Answers 2

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related