Angular.forEach loop is not working properly

Question

PFB the code of my custom filter where it takes a parameter viewbookoption which is a dropdown value. Based on the dropdown value,the data will be shown in the grid.I implemented forEach loop here but it is not working properly and it keeps traversing the loop and gives me close to 10000 records but actually I have only 10 records which should be displayed in the grid.

Any help in this regard will be much appreciated.

    Controllers.filter('filterUnissued', function() {
     return function(books, viewbookoption) {
       if (viewbookoption == "All Books") {
         return books;
       } else {
         angular.forEach(books, function(book) {
           if (book.issued == false) {
             books.push(book);
           }
        });
      }
      return books;
    }
});

You are iterating the same array you are pushing into

charlietfl
– charlietfl

2016-06-21 02:20:34 +00:00
Commented Jun 21, 2016 at 2:20 — charlietfl
– charlietfl, Commented Jun 21, 2016 at 2:20
Yeah!! My bad..Thanks for guidance

Voyager3
– Voyager3

2016-06-21 02:31:05 +00:00
Commented Jun 21, 2016 at 2:31 — Voyager3
– Voyager3, Commented Jun 21, 2016 at 2:31

Andrew Eisenberg · Accepted Answer · 2016-06-21 02:19:46Z

3

You are pushing elements onto the existing books array. Instead, you should create a new array and push onto that. Like this:

var filteredBooks = []
angular.forEach(books, function(book) {
   if (book.issued == false) {
     filteredBooks.push(book);
   }
});
return filteredBooks;

Or, better, use the Array.filter.prototype method:

return books.filter(function(book) {
  return book.issued === false;
});

(Also, always use === instead of ==, unless you have a very good reason to use ==.)

answered Jun 21, 2016 at 2:19

Andrew Eisenberg

28.9k9 gold badges100 silver badges157 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

Andrew Eisenberg Over a year ago

No problem! Welcome to Stackoverflow. I hope you find it useful here.

Collectives™ on Stack Overflow

Angular.forEach loop is not working properly

1 Answer 1

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related