Symfony centralize code

Question

I am new to symfony 2.8. I do the same code pattern in each of my controllers to get the same data, put in different views, following this pattern:

 public function someMethod(Request $request){
    //1)  instanciate entity manager 
    $em = $this->getDoctrine()->getManager();

    //2)   Fetch some datas ..
    $datas = $em->getRepository('MyCustomBundle:Entity')->findAll();
    $otherDatas = $em->getRepository('MyCustomBundle:AnotherEntity')->findAll();

   //3) Inject datas into view
   return $this->render('MyCustomBundle:Views:myview.html.twig', array('data'=>$datas,'otherDatas'=>$otherDatas));
   }

Is it possible to factorize all the getRepositories calls and arrays injection into a separated class ?

thanks for your help,

Sure. Get familiar with dependency injection and services symfony.com/doc/current/service_container.html. Define your repositories as services and use $this->get('my.repository')->findAll(). Next, consider define your controllers as services so even the get can go away. Lots of other things you can do as well. — Cerad
– Cerad, Commented Aug 2, 2016 at 17:28

Andreas Dyballa · Accepted Answer · 2016-08-02 16:54:40Z

1

I dont think there is a Symfony-way. I would prefer 2.) and put your Code in the repository and just put some getters in the controller.

Make an abstract Controller class from which you inherit from.
I would do it with some redundant code. Put your repository getters in a method. Clean but redundant. If you have some complicated DB-Handling, put your code in the reposistory.
Build a service with your code and associate it in your Controller-Service. Take a look here
Put your code in a trait.

answered Aug 2, 2016 at 16:54

Andreas Dyballa

1891 silver badge5 bronze badges

Sign up to request clarification or add additional context in comments.

Collectives™ on Stack Overflow

Symfony centralize code

1 Answer 1

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

Comments

Your Answer

Sign up or log in

Post as a guest

Related