Java script: not working .innerHTML

Question

I'm making a simple calculator and my function is not working:

HTML:

<div id="mathLine">0</div>
<div id="score">none</div>
<button id="clear" class = "num" ocnlick="clear(0)">C</button>
<button id="exp" class = "num" >exp</button>
<button id="sqrt" class = "num">sqrt</button>
<button id="buttonide" class = "num">/</button>
<button id="seven7" class = "num" onclick="numerical(7)">7</button>
<button id="eight8" class = "num" onclick="numerical(8)">8</button>
<button id="nine9" class = "num" onclick="numerical(9)">9</button>
<button id="multiply" class = "num" onclick="numerical('X')">X</button>

JS

var equation = [];  
function numerical(number){
    equation.push(number);
    document.getElementById('mathLine').innerHTML = equation;
    console.log(equation);
};
function clear (j) {
    for (j; j < (equation.length+2); j++){
    equation.pop();
    }
    console.log(equation);
    document.getElementById('mathLine').innerHTML = "0";
};

Some more info:

js file is correctly implemented in html;
the first function (numerical) is working fine;
List item when I tried it in separate html file, where I put html and js in tag it all worked

So I have no idea, what's wrong... Maybe I'm looking at it too long and I'm not seeing something obvious?

Have you tried using a debugger such as FireBug to get any error messages? — atjoedonahue
– atjoedonahue, Commented Aug 3, 2016 at 19:36
You haven't asked a question, and you haven't said specifically what isn't working. What exactly is the problem you need help with? — dlsso
– dlsso, Commented Aug 3, 2016 at 19:36
@dlsso It's not as clear as it could be, but Olka says that the first function works, but not the second - and the question title indicates .innerHTML is not working as expected. It sounds like the mathLine's text does not change. — Katana314
– Katana314, Commented Aug 3, 2016 at 19:38
StackOverflow is not your personal debugger to detect your typos. Use a proper debugger. Even the StackOverflow syntax highlighter tells there is something wrong with that event handler. — Oriol
– Oriol, Commented Aug 3, 2016 at 19:41

atjoedonahue · Accepted Answer · 2016-08-03 19:37:02Z

1

You have a typo. Try changing "ocnlick" to "onclick."

answered Aug 3, 2016 at 19:37

atjoedonahue

4847 silver badges19 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

Olka Over a year ago

Oh, that's right! It's still not working, but it's one step forward:)

Katana314 · Accepted Answer · 2016-08-03 19:35:49Z

0

My belief here is that your array-clearing is not working - it's usually not safe to iterate through an array while you are removing elements from it, as the indexing can get messed up. You could perhaps replace the for loop with a while loop checking the array's length, but a simple suggestion would be instead to reassign the array:

equation = [];

answered Aug 3, 2016 at 19:35

Katana314

8,6052 gold badges31 silver badges36 bronze badges

1 Comment

Olka Over a year ago

I'll try this. Thank you!

Collectives™ on Stack Overflow

Java script: not working .innerHTML

2 Answers 2

1 Comment

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

1 Comment

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related