Encoded Javascript Not Working

Question

The javascript encoded into my html is not working. It is supposed to find the best out of the players listed, and then alert who is the best. When I run it, all of the HTML and CSS aspects show, but there is no alert. Please help. It might just be a syntax error or something but please still help! Here is the code:

<script>
            var players = [
                {name: "Pat Moran", overall: 67, position: 1},
                {name: "Peter Webb", overall: 81, position: 1},
                {name: "Ramiro Ramirez", overall: 74, position: 1}
            ];

            function findBestPlayer() {
                var bestSoFar = 0;
                var bestPlayer;
                for (var i = 0; i < players.length; i++) {
                    if (players[i].overall > bestSoFar) {
                        bestPlayer = players[i];
                        bestSoFar = players[i].overall;
                    }
                }
                return best;
            }

            var bestPlayer = findBestPlayer();
            alert("Best player is " + bestPlayer.name + " with an overall of " + bestPlayer.overall ;
        </script>

technico · Accepted Answer · 2016-08-06 03:05:11Z

            var players = [
                {name: "Pat Moran", overall: 67, position: 1},
                {name: "Peter Webb", overall: 81, position: 1},
                {name: "Ramiro Ramirez", overall: 74, position: 1}
            ];

            function findBestPlayer() {
                var bestSoFar = 0;
                var bestPlayer;
                for (var i = 0; i < players.length; i++) {
                    if (players[i].overall > bestSoFar) {
                        bestPlayer = players[i];
                        bestSoFar = players[i].overall;
                    }
                }

                return bestPlayer;
            }

            var bestPlayer = findBestPlayer();
            alert("Best player is " + bestPlayer.name + " with an overall of " + bestPlayer.overall) ;

The closing parenthesis is missing for the alert function. Edit : corrected the bestPlayer instead of best. Thanks to runner and joseph.

Runner · Accepted Answer · 2016-08-06 03:05:18Z

1

I'm answering this mobily, so I can't debug it, but in the function findBestPlayer you return best instead of bestPlayer.

answered Aug 6, 2016 at 3:05

Runner

2522 silver badges9 bronze badges

Comments

Shintu Joseph · Accepted Answer · 2016-08-06 03:34:57Z

1

return best; is not defined - use return bestPlayer; in that place, and include a brace after the alert end

edited Aug 6, 2016 at 3:34

answered Aug 6, 2016 at 3:04

Shintu Joseph

9627 silver badges19 bronze badges

Comments

ubm · Accepted Answer · 2016-08-06 03:57:12Z

here best is not defined and missing brackets in alert

 var players = [
                {name: "Pat Moran", overall: 67, position: 1},
                {name: "Peter Webb", overall: 81, position: 1},
                {name: "Ramiro Ramirez", overall: 74, position: 1}
            ];

            function findBestPlayer() {
                var bestSoFar = 0;
                var bestPlayer;
                for (var i = 0; i < players.length; i++) {
                    if (players[i].overall > bestSoFar) {
                        bestPlayer = players[i];
                        bestSoFar = players[i].overall;
                    }
                }
                return bestPlayer;
            }
          var bestPlayer = findBestPlayer();
            alert("Best player is " + bestPlayer.name + " with an overall of " + bestPlayer.overall) ;

Collectives™ on Stack Overflow

Encoded Javascript Not Working

4 Answers 4

Comments

Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

4 Answers 4

Comments

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related