Python script makes a file but doesn't write anything

Question

First, code gets a name and makes a file with w permission (also tested r+) and it should write any other input in file, but it doesn't. I get an empty file.

user_name_in =input("gets Input")
fname = user_name_in
f = input()
ufile = open(fname,"w")
while True:
    f=input(answer)
    ufile.write(f)

Have you tried with open(fname, 'w') as ufile: ufile.write(f) ? — mbednarski
– mbednarski, Commented Aug 22, 2016 at 12:16
@Rawing you would still have to flush the file. always use the with to handle files. — Ma0
– Ma0, Commented Aug 22, 2016 at 12:17
@MohammadHoseinBin Did you add it at the very end outside the loop? Also, have something that terminates the loop so it can reach the end — Andrew Li
– Andrew Li, Commented Aug 22, 2016 at 12:19

Ma0 · Accepted Answer · 2016-08-22 12:24:10Z

5

As i wrote in the comments, always use the with block to handle files as it takes care of intricacies you don't have to worry about. Now on the code, you repeat yourself, for example the first two lines are actually one.. This is what it would look when cleaned a bit.

fname = input("gets Input")
with open(fname, "w") as ufile:
    f = input('write something')
    ufile.write(f)

And as others also noticed, the answer is never declared, there is no termination condition and the input prompts are either not the best or totally absent.

edited Aug 22, 2016 at 12:24

answered Aug 22, 2016 at 12:20

Ma0

15.2k4 gold badges38 silver badges70 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

Mike Maazallahi Over a year ago

Answer is declared somewhere else , I declared it externally in String management part of program.

dfranca · Accepted Answer · 2016-08-22 12:20:17Z

1

This code works for me:

user_name_in =input("gets Input")
fname = user_name_in
f = input()
ufile = open(fname,"w")
while True:
    f=input(answer)
    ufile.write(f)

Some considerations: I don't see where answer is declared, neither python interpreter see :P, maybe you forgot to paste this part of the code or indeed this was the error?

I don't understand why you assign the name of the file to a variable and then re-assign to another one.

How do I stop writing to the file? The only way I found was Ctrl-C, which doesn't sound ideal.

To reassure the file is being closed you can replace it with a with open(fname) as ufile block

answered Aug 22, 2016 at 12:20

dfranca

5,3622 gold badges36 silver badges66 bronze badges

1 Comment

Mike Maazallahi Over a year ago

f variable got same use and in optimized final code will be fixed. there are if's in while that'll break the loop. i just placed only necessary parts of Code

Collectives™ on Stack Overflow

Python script makes a file but doesn't write anything

2 Answers 2

1 Comment

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

1 Comment

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related