Executing UPDATE statement with mysqljs

Question

Im using mysqljs and I'm trying to UPDATE a table but it shows me an error with my SQL sentence.

the documentation states that

connection.query('UPDATE users SET foo = ?, bar = ?, baz = ? WHERE id = ?', ['a', 'b', 'c', userId], function(err, results) {
  // ...
});

But when I try to do it, the query creates all the variables that I'm sending to the first ?, ignorign the other ones, like this

values = [1,2,3,4,5]
sql = 'UPDATE tablename SET col1= ?, col2 = ?, col3= ?, col4 = ? WHERE col5=  ?';

  var query = connection.query(sql, [values], function(err) {
      if (err) {
        console.log(err);
        throw err;
      }
      else {
        connection.end();
      }
  })

But the query that gets executes is:

UPDATE tablename SET col1= 1, 2, 3, 4, col2 = ?, col3= ?, col4 = ? WHERE col5=  ?';

I don't know what I'm doing wrong or what to do to fix it.

Michael Lorton · Accepted Answer · 2016-10-04 19:48:27Z

1

You aren't passing an array of values, you are passing an array of an array of values. Stop doing that.

answered Oct 4, 2016 at 19:48

Michael Lorton

44.7k26 gold badges111 silver badges159 bronze badges

Sign up to request clarification or add additional context in comments.

4 Comments

Robert Parham Over a year ago

to clarify.. connection.query(sql, values, function(err) {

Sebastian Chavez Irurzo Over a year ago

I see, but I was doing that because if I do an INSERT, and pass values like this connection.query(sql, values, function(err) , it shows an error, and dont let me save it

Sebastian Chavez Irurzo Over a year ago

Only inserts the first value, if values=[1,2,3] the query is this INSERT INTO table (col1,col2,col3) VALUES (1), but when I put values between brackets [values] INSERT INTO table (col1,col2,col3) VALUES (1,2,3)

Michael Lorton Over a year ago

@SebastianChavezIrurzo -- you are saying the behavior of query() is difference based on whether the command is INSERT or UPDATE? I have to say, I am very skeptical. Go back and look at the code again carefully.

Collectives™ on Stack Overflow

Executing UPDATE statement with mysqljs

1 Answer 1

4 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

4 Comments

Your Answer

Sign up or log in

Post as a guest

Related