PHP/MySQL convert 'while' statements to 'foreach'

Question

Following on from a previous question, shown here, I was wondering how I would go about changing the code below into 'foreach' statements? Any help greatly appreciated, S.

<div id="banner-wrap">          
    <div id="banner" class="gallery">               
        <ul class="galleryBar">               

                <?php       
                $homeB=mysql_query("select * from istable where fpGallery = '1' ORDER BY RAND() LIMIT 0, 5");
                while($homeG=mysql_fetch_array($homeB)) {   
                $linkcode = $homeG['title'];
                $linkcode = str_replace(" ","",$linkcode);
                echo '
                <li>
                <a href="'.$wwwUrl.'images/'.$homeG['image'].'" rel="'.$linkcode.'">
                <img src="'.$wwwUrl.'images/tn/'.$homeG['image'].'" width="75" height="55" alt="'.$homeG['title'].'" />
                </a>
                </li>                       
                ';
                }                                   

        echo '</ul>';
         echo '</div>'; 

                while($homeGal=mysql_fetch_array($homeB)) {                             
                echo '
                <div id="'.$linkcode.'" class="overlay">
                    <h3>'.$homeGal['title'].'</h3>
                    <h4>'.$homeGal['location'].'</h4>                           
                </div>                                              
                ';
                }

                ?>          
    </div>

AlexV · Accepted Answer · 2010-10-29 12:59:14Z

2

You can't replace your while for a foreach in this situation. mysql_fetch_array / mysql_fetch_assoc only returns one row and not the whole result set from the resource passed (if the internal pointer of the connection resource is at the end, false is returned).

In your case if you need the whole result set and then work with it in a foreach you can always fetch the whole result set in an array (with a while) and then work with the array with a foreach (see infinity answer for an example). This will take much more memory/slow down the process if you have a huge result set.

edited Oct 29, 2010 at 12:59

answered Oct 29, 2010 at 12:50

AlexV

23.2k21 gold badges89 silver badges132 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Alex Rashkov · Accepted Answer · 2010-10-29 12:56:57Z

1

You can do something like:

$data = array();
while($homeG=mysql_fetch_array($homeB)) {   
    $data[] = $homeG;
}

foreach($data as $row) {
    // your code hre
}

But my advice to you is split your programming logic and view logic/code. You'd better try to create something as Model View Controller [ http://en.wikipedia.org/wiki/Model–View–Controller ]

or use a PHP Framework (CakePHP, Zend Framework, CodeIgniter)

edited Oct 29, 2010 at 12:56

answered Oct 29, 2010 at 12:50

Alex Rashkov

10k3 gold badges35 silver badges57 bronze badges

1 Comment

ss888 Over a year ago

Brilliant - adapted my code with your example and it works perfectly! Many thanks to you and all other members.

Álvaro González · Accepted Answer · 2010-10-29 12:56:44Z

1

You'd have to encapsulate the database access with a custom class that implements the Iterator interface or drop the mysql_*() functions in favour of another library that provides classes that already implement such interface, such as PDO.

I believe that this kind of change, although interesting in the long term, makes little sense in your current situation. You should first become proficient in the use of arrays.

answered Oct 29, 2010 at 12:56

Álvaro González

147k45 gold badges282 silver badges378 bronze badges

Comments

Spudley · Accepted Answer · 2010-10-29 12:52:21Z

0

You can't get rid of the while loop, as the mysql_fetch functions only return one row at a time.

If you really wanted a foreach() loop, you could use a while loop and mysql_fetch to populate the data into an array, and then do a foreach loop after that on that array. That would give you a foreach, but it wouldn't get rid of the while.

answered Oct 29, 2010 at 12:52

Spudley

169k39 gold badges240 silver badges309 bronze badges

Comments

Semu · Accepted Answer · 2016-04-14 01:30:18Z

0

While loop foreach()

DB CREATE

id

title

href

img

<?php 
   $this = array();

   $db = mysql_query('SELECT * FROM `'.DB_PREFIX.'product` where id order by id asc', ConnectDb()); // ConnectDb() to PHP Deprecated: mysql_query() error fix

   while($see=mysql_fetch_array($db)) {   
         $this[] = $see;
   }
?>

<ul class="product">
  <?php foreach ($this as $product) { ?>
    <li><a href="<?php echo $product['href']; ?>" title="<?php echo $product['title']; ?>"><img src="<?php echo $product['img']; ?>" alt="<?php echo $product['title']; ?>"><?php echo $product['title']; ?></a></li>
  <?php } ?>
</ul>

answered Apr 14, 2016 at 1:30

Semu

443 bronze badges

Collectives™ on Stack Overflow

PHP/MySQL convert 'while' statements to 'foreach'

5 Answers 5

Comments

1 Comment

Comments

Comments

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

5 Answers 5

Comments

1 Comment

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related