remove last comma from string in while loop in php?

Question

I am using while loop to get values from my database and my result is like:

I want to remove comma after last value of loop.

i used code like..

<?php
 $cat = get_terms('car_category'); // you can put your custom taxonomy name as place of category.
        foreach ($cat as $catVal) {
            echo '<b>'.$catVal->name.'</b>';
            $postArg = array('post_type'=>'cars','posts_per_page'=>5,'order'=>'desc',
                              'tax_query' => array(
                                                    array(
                                                        'taxonomy' => 'car_category',
                                                        'field' => 'term_id',
                                                        'terms' => $catVal->term_id
                                                    )
                            ));

            $getPost = new wp_query($postArg);
            global $post;

            if($getPost->have_posts()){
                $str = "";
                echo '<div class="yearDiv">';
                    while ( $getPost->have_posts()):$getPost->the_post();
                        $str =rtrim($post->post_title, ",");
                        echo '<span>'.$str.',</span>';
                    endwhile;
                echo '</div>';
            }
        }
?>

i used rtrim , substr function also for it but comma not removing.

Jigar7521 · Accepted Answer · 2016-11-10 06:17:22Z

3

Utilize rtrim for it. Just make sure at the end of the string space should not be there after comma.

   $yourString = rtrim($yourString, ",");

edited Nov 10, 2016 at 6:17

answered Nov 10, 2016 at 5:40

Jigar7521

1,5791 gold badge14 silver badges29 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Prakash Rao · Accepted Answer · 2016-11-10 05:41:49Z

Take the post titles in an array and Use Implode instead ..

<?php
 $cat = get_terms('car_category'); // you can put your custom taxonomy name as place of category.
        foreach ($cat as $catVal) {
            echo '<b>'.$catVal->name.'</b>';
            $postArg = array('post_type'=>'cars','posts_per_page'=>5,'order'=>'desc',
                              'tax_query' => array(
                                                    array(
                                                        'taxonomy' => 'car_category',
                                                        'field' => 'term_id',
                                                        'terms' => $catVal->term_id
                                                    )
                            ));

            $getPost = new wp_query($postArg);
            global $post;

            if($getPost->have_posts()){
                $str = array();

                    while ( $getPost->have_posts()):$getPost->the_post();
                        $str[] = $post->post_title;

                    endwhile;
            }
            echo '<div class="yearDiv">';
            echo '<span>'.implode(', ', $str).'</span>';
            echo '</div>'
        }
?>

L. Herrera · Accepted Answer · 2016-11-10 05:39:42Z

0

Have you tried removing the rtrim on the while loop but instead after looping you make the rtrim function? Like this:

echo '<div class="yearDiv">';
    while ( $getPost->have_posts()):$getPost->the_post();
        $str .= $post->post_title . ",";
    endwhile;
    echo '<span>'.rtrim($str, ",").'</span>';
echo '</div>';

answered Nov 10, 2016 at 5:39

L. Herrera

4904 silver badges13 bronze badges

2 Comments

maddy Over a year ago

Yes i tried it but it only giving me first value of loop like.. Aprilia Dorsoduro 750 ABS, PRI PRIMODE, Yamaha XS650, Zero S,

L. Herrera Over a year ago

Ah yes, you have to use concat for the strings.. glueing all your $post->post_title.. try again this time.

vikas pandey · Accepted Answer · 2016-11-10 05:45:05Z

0

echo '<div class="yearDiv">';
$str = "";
while ( $getPost->have_posts()):$getPost->the_post();
    $str .= $post->post_title.",";
endwhile;

try

if(substr($str, -1) == ',') {
   $str = substr($str, 0, -1);
}

or

$str = rtrim($str,",");

...

echo '<span>'.$str.'</span>';
echo '</div>';

answered Nov 10, 2016 at 5:45

vikas pandey

2041 silver badge7 bronze badges

Comments

Shuhad zaman · Accepted Answer · 2017-01-01 13:58:12Z

0

Php has a trim function

<?php
$str = "item one ,item tow,item three,item 4,";
echo trim($str, ",");
?>

the output will be like this

item one ,item tow,item three,item 4

answered Jan 1, 2017 at 13:58

Shuhad zaman

2,90034 silver badges33 bronze badges

1 Comment

LizardKG Over a year ago

No, the output will be like this "item one item tow item three item 4 " because it will remove the comma from every iteration of the loop

Collectives™ on Stack Overflow

remove last comma from string in while loop in php?

5 Answers 5

Comments

Comments

2 Comments

Comments

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

5 Answers 5

Comments

Comments

2 Comments

Comments

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related