filtering an element from object array

Question

I have an array of object something like below

Object[0]

canUpload:false
canBeRemoved:true
  type:Object
    allowMultiple:false
    deleted:false
    key:"testValue"

Object[1]
canUpload:true
canBeRemoved:true
 type:Object
   allowMultiple:false
   deleted:false
   key:"testValue2"

I want to remove an elements from array which contains key:testValue

var myValues = this.testData.data3;

        if(!this.testData.canDownload){
  myValues= myValues.filter(function(value){
                    if(!value.canUpload)
                        return value.type.key==='testValue';
                else return false;
                });

But its not removing .Whats the right way to do it? Here is the full code .I can see myValues array of size 2 .If i print myValues after if block its empty. Code pen:http://codepen.io/developer301985/pen/woGBNg

What is expected result of of value.canUpload at if condition? — guest271314
– guest271314, Commented Nov 12, 2016 at 1:59
if value.canUpload= false In the array I want to upload.In developer console I dont see execution entering that point if(!value.canUpload) — javascriptlearner
– javascriptlearner, Commented Nov 12, 2016 at 2:04

Basim Hennawi · Accepted Answer · 2016-11-12 01:46:44Z

1

If your want to filter your array on the basis of two conditions:

canUpload attr is false
type.key is equal to 'testValue'

so you may want to return false in case of canUpload is true to be as follow:

myValues= myValues.filter(function(value) {
  if(!value.canUpload)
    return value.type.key === 'testValue';
  else return false;
});

Otherwise, you just want to filter on type.key is equal to 'testValue', so it will be as follow:

myValues= myValues.filter(function(value) {
  return value.type.key === 'testValue';
});

answered Nov 12, 2016 at 1:46

Basim Hennawi

2,7213 gold badges22 silver badges31 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

javascriptlearner Over a year ago

myValues is empty after outer if block. Not sure If I am doing right

Basim Hennawi Over a year ago

Make sure myValues is parsed as array of objects, also if you could get your code on Codepen to clarify your case more, it'll be better.

LeOn - Han Li · Accepted Answer · 2016-11-15 20:36:55Z

0

Note, if the callback function you passed into filter returns true, the element will be kept rather than removed. So in your case, you should return false when the value is testValue.

If I understand you correctly, you want to remove item with value.canUpload==false AND type.key === 'testValue'. Then the negate is value.canUpload || value.type.key !== 'testValue'

var myValues = this.testData.data3;

if (!this.testData.canDownload) {
    myValues = myValues.filter(function(value) {
        return value.canUpload || value.type.key !== 'testValue';
    });
}

Let me know whether it works :)

answered Nov 15, 2016 at 20:36

LeOn - Han Li

10.4k2 gold badges70 silver badges63 bronze badges

Collectives™ on Stack Overflow

filtering an element from object array

2 Answers 2

2 Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

2 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related