Update data using SQL parameter in C# with class

Question

I have a question regarding on update using SqlParameter with class...

In my class EditRecord:

string strScript = "";
strScript = strScript + "UPDATE tbMemberInfo(FirstName,LastName,Age)";
strScript = strScript + "SET (FirstName = @firstname, LastName = @lastname, Age = @age)";
strScript = strScript + "WHERE id=@empID";

SqlCommand cmd;
cmd = new SqlCommand(strScript, Connection);
cmd.CommandTimeout = 0;

cmd.Parameters.AddWithValue("@firstname", _members.Lastname));
cmd.Parameters.AddWithValue("@lastname", _members.FirstName));
cmd.Parameters.AddWithValue("@age", _members.Age));
cmd.Parameters.AddWithValue("@empID", _members.ID));
cmd.ExecuteNonQuery();

Call the class in my Form

Class.clsMemberInfo member = new Class.clsMemberInfo();

member.FirstName = txtFirstName.Text;
member.Lastname = txtLastName.Text;
member.Age = Convert.ToInt32(txtAge.Text);

clsMembers memberInfo = new clsMembers();

memberInfo.Members = member;
memberInfo.EditREcord(cnTestConnection);
MessageBox.Show("Success");

But the data is not updating

Your query seems off. You need a space after each string. So: "UPDATE tbMemberInfo(FirstName,LastName,Age) " Also, make sure you have opened a connection — user4189129
– user4189129, Commented Dec 6, 2016 at 8:12
Your sql maybe upset because between age) and set there is no space, same as there is no space between @age and where. — BugFinder
– BugFinder, Commented Dec 6, 2016 at 8:12
debug your code, get sql script string before execute it and then run it on Sql Server. you will not be surprised, trust me. — Badiparmagi
– Badiparmagi, Commented Dec 6, 2016 at 8:15
Thank you sir for your response but no change at all still I cannot update the data.... :( — Jolan Moski
– Jolan Moski, Commented Dec 6, 2016 at 8:15
@JolanMoski, if you "cannot update data" then there is probably an error occurring, which we need to know. Details are important! — Peter B
– Peter B, Commented Dec 6, 2016 at 8:27

Damith · Accepted Answer · 2016-12-06 09:46:16Z

1

change sql statement as

string strScript = "UPDATE tbMemberInfo SET FirstName = @firstname, LastName = @lastname, Age = @age WHERE id=@empID";

update syntax is

UPDATE table_name
SET column1=value1,column2=value2,...
WHERE some_column=some_value;

there is no column names given in () next to table name

UPDATE

in your code _members.ID is not set before you call the method

Class.clsMemberInfo member = new Class.clsMemberInfo();

member.FirstName = txtFirstName.Text;
member.Lastname = txtLastName.Text;
member.Age = Convert.ToInt32(txtAge.Text);
member.ID  = ??? //you need to give this value, otherwise your update will not work

edited Dec 6, 2016 at 9:46

answered Dec 6, 2016 at 8:14

Damith

63.2k13 gold badges106 silver badges154 bronze badges

Sign up to request clarification or add additional context in comments.

6 Comments

Damith Over a year ago

Care to explain down votes! may be i'm wrong but there is clearly syntax issue with the OPs code

Jolan Moski Over a year ago

I have already edit my update sql but still cannot update my data

Peter B Over a year ago

@JolanMoski, if you "cannot update data" then there is probably an error occurring, which we need to know. Details are important!

Jolan Moski Over a year ago

What additional detail you need to know Sir Peter B?

Jolan Moski Over a year ago

Your code worked Sir Poovizhi! Now how do i change the value of your sql statements? :)

|

Collectives™ on Stack Overflow

Update data using SQL parameter in C# with class

1 Answer 1

6 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

6 Comments

Your Answer

Sign up or log in

Post as a guest

Related