strange variable behaviour in php although data is available in variable

Question

I am updating IP location in database using third party free service by a small php script. It was working fine but suddenly it stopped working. I tried to figure out what happened but I could not. Here is my script

<?
$sno = 0;
$query = "SELECT date,ac_no,ip,country FROM visitors where $mainfilter order by ac_no,date desc limit 0,$maximumips;";

$result = db_query($query,"&nbsp;");
while($line=db_fetch_array($result))
{

$country = "";
$updatestatus = "";
$ip = $line[ip];
$sno = $sno + 1;

if($updateip=="Yes")
{
    $ip_data = @json_decode(file_get_contents("http://www.geoplugin.net/json.gp?ip=".$ip));
    if($ip_data && $ip_data->geoplugin_countryName != null)
    {
        $country = $ip_data->geoplugin_countryName;
    }

    if($country!="")
    {
        $q_det = "update visitors set country='$country' where ip='$line[ip]'";
        db_exec($q_det);

        $q_det = "update ips set country='$country' where ip='$line[ip]'";
        db_exec($q_det);
        $updatestatus = "Yes - External";
    } else {
        $updatestatus = "No Trace";
    }
    sleep($waitseconds);        
}

echo "$sno | $line[date] | $line[ac_no] | $ip | $country | $updatestatus";?><br><?
}
?>

The problem is following command $ip = $line[ip];

In cpanel errorlog it says "Use of undefined constant ip - assumed 'ip' in /home/"

However when I use "echo $ip" it prints the ip, it means ip is stored in this variable but on other side it gives above mention error in cpanel.

Earlier I was using $line[ip] variable directly to get country name in following command and it was working perfectly but suddenly it stopped.

        $ip_data = @json_decode(file_get_contents("http://www.geoplugin.net/json.gp?ip=".$line[ip]));

Then I thought to store IP in $ip variable and then use there but still it does not work.

Please help me to know why cpanel givers error and script stopd although it was working fine and also data is stored in $ip variable which shows when "echo $ip" is used.

Thanks for help

Samir Selia · Accepted Answer · 2016-12-09 06:51:07Z

2

Enclosing array key in quotes '' will fix it. Without quotes PHP assumes it a CONSTANT and hence throws an error.

$ip = $line['ip'];

Also change variable name in your UPDATE queries.

$q_det = "update visitors set country='$country' where ip='$ip'";
$q_det = "update ips set country='$country' where ip='$ip'";

edited Dec 9, 2016 at 6:51

answered Dec 9, 2016 at 6:35

Samir Selia

7,1502 gold badges14 silver badges33 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

arif_suhail_123 Over a year ago

his query part is still wrong, he can't just add single qoute around ip in there, correct the query as well please

Moonblaze · Accepted Answer · 2016-12-09 07:00:31Z

1

Try changing $ip = $line[ip] to $ip = $line['ip'] using ip without quotes php treats it like it's a constant

And to fix your queries

$q_det = "update visitors set country='$country' where ip=$ip";
db_exec($q_det);

$q_det = "update ips set country='$country' where ip=$ip";
db_exec($q_det);

edited Dec 9, 2016 at 7:00

answered Dec 9, 2016 at 6:37

Moonblaze

1631 silver badge13 bronze badges

2 Comments

arif_suhail_123 Over a year ago

his query part is still wrong, he can't just add single qoute around ip in there, correct the query as well please

Moonblaze Over a year ago

Done. I think both me and Samir assumed he was using the variable instead of $line[ip] because he said "Then I thought to store IP in $ip variable and then use there but still it does not work."

Collectives™ on Stack Overflow

strange variable behaviour in php although data is available in variable

2 Answers 2

1 Comment

2 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

1 Comment

2 Comments

Your Answer

Sign up or log in

Post as a guest

Related