String to Boolean using ternary operator in Javascript?

Question

I have a result coming from PHP side and json_encode send all the values as string (not as it's original type). The string coming at quote_tax is a 1|0 and of course this is true|false for example:

{
  "country_id": "3",
  "country_name": "Italy",
  "contract_tax": "1",
  "quote_tax": "0",
  "contract_inflation": "0",
  "quote_inflation": "0"
}

When I want to perform some operation based on such values and because they are coming as string I need to do something like this:

 data.quote_tax == '1' 
                ? $('#contract_tax').val(1).attr('checked', 'checked') 
                : $('#contract_tax').val(0).removeAttr('checked');

I did know about .parseInt() to convert them into a integer but I believe then I would need to have the same comparison but this case comparing with INT:

 data.quote_tax == 1 
                ? $('#contract_tax').val(1).attr('checked', 'checked') 
                : $('#contract_tax').val(0).removeAttr('checked');

I have tried this way:

 Boolean(data.quote_tax) == true 
                ? $('#contract_tax').val(1).attr('checked', 'checked') 
                : $('#contract_tax').val(0).removeAttr('checked');

And it doesn't work since Boolean(data.quote_tax) always evaluate as true even if data.quote_tax = '0'.

I have check this posts already but I couldn't found a proper solution:

Any ideas what's wrong here or how to do this?

"0" is truthy as it’s a non-empty string. "" and 0 are falsey. Try Boolean(Number(data.quote_tax)) == true or simply +data.quote_tax as the condition. — Sebastian Simon
– Sebastian Simon, Commented Dec 9, 2016 at 15:53

Community · Accepted Answer · 2017-05-23 12:18:35Z

7

Values in Javascript are either "truthy" or "falsy", meaning they'll be interpreted as true or false in a boolean context. In the case of numbers, 0 is false and all others are true. If you convert your value to a number, you don't have to perform any other conversion to treat it as a boolean.

var x = parseInt('1');
x ? console.log(true) : console.log(false);

x = parseInt('0');
x ? console.log(true) : console.log(false);

See here for more information.

edited May 23, 2017 at 12:18

CommunityBot

11 silver badge

answered Dec 9, 2016 at 15:55

Mike Cluck

32.6k13 gold badges84 silver badges95 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

ReynierPM Over a year ago

All answers are good but this one is so far the best one, thanks it works

Ori Drori · Accepted Answer · 2016-12-09 15:56:37Z

2

You can combine the operators - parse the string to a number, and then convert to Boolean:

console.log(Boolean(parseInt('0', 10)));

console.log(!!parseInt('0', 10));

console.log(!!+'0');

edited Dec 9, 2016 at 15:56

answered Dec 9, 2016 at 15:54

Ori Drori

196k32 gold badges243 silver badges233 bronze badges

1 Comment

Shilly Over a year ago

Or just use !!parseInt('0', 10);

TimoStaudinger · Accepted Answer · 2016-12-09 15:59:52Z

2

Your last approach fails because any non-empty string evaluates to true if converted to a boolean, including "0".

The integer 0 evaluates to false, while non-zero integers evaluate to true. For this reason, parseInt(data.quote_tax) == 1 would be equivalent to parseInt(data.quote_tax) in your case.

However, I would stick with the first approach in this situation:

data.quote_tax == '1'

This requires no type conversions, the intent is immediately obvious and is also doesn't require the developer to know the things I listed above to be understood. Don't make your code more complicated than it has to be.

answered Dec 9, 2016 at 15:59

TimoStaudinger

42.7k16 gold badges91 silver badges96 bronze badges

Comments

Piotr Białek · Accepted Answer · 2016-12-09 16:05:29Z

1

You can do something like this:

!!parseInt('1'); //true
!!parseInt('0'); //false

edited Dec 9, 2016 at 16:05

answered Dec 9, 2016 at 15:57

Piotr Białek

2,7571 gold badge19 silver badges27 bronze badges

Comments

Community · Accepted Answer · 2017-05-23 11:47:35Z

Personally I always try and stay away from coercing types. The problem is that if you do as others have suggested, if (x) this works great for 0 & 1. What if for some reason you get a "false", 2, null or undefined. What would you want your code to do here?

undefined ? console.log(true) : console.log(false);
null ? console.log(true) : console.log(false);
NaN ? console.log(true) : console.log(false);
2 ? console.log(true) : console.log(false);
"false" ? console.log(true) : console.log(false);
"true" ? console.log(true) : console.log(false);

If you use === (as opposed to ==) it prevents Javascript coercion. You can then test for the string value "1"

"1" === "1" ? console.log(true) : console.log(false);
1 === "1" ? console.log(true) : console.log(false);
undefined === "1" ? console.log(true) : console.log(false);
null === "1" ? console.log(true) : console.log(false);
NaN === "1" ? console.log(true) : console.log(false);
2 === "1" ? console.log(true) : console.log(false);
"false" === "1" ? console.log(true) : console.log(false);
"true" === "1" ? console.log(true) : console.log(false);

It now works a lot more consistently. May or may not be an issue in your case but I prefer this method for the just in case factor.

Collectives™ on Stack Overflow

String to Boolean using ternary operator in Javascript?

5 Answers 5

1 Comment

1 Comment

Comments

Comments

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

5 Answers 5

1 Comment

1 Comment

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related