Bash file script escaping user input

Question

This bash script when run on Mac terminal, it needs to ask for user input, then it needs to check if a a string "PLACEHOLDER_BACKEND_NAME="user-input" exists in a given file and if not it should exit the script.

echo -e "${YELLOW}enter app name${WHITE}"
    read name

line=grep $name /path/to/file/entrypoint.sh

if [[ line != "PLACEHOLDER_BACKEND_NAME=\"$name\"" ]] ; then
    exit 1
fi

It needs much tuning as I am not very familiar with bash scripts. any suggestions? thx

codeforester · Accepted Answer · 2016-12-26 00:12:07Z

1

Your code needs a little tweaking:

echo -e "${YELLOW}enter app name${WHITE}"
read -r name

if ! grep -q PLACEHOLDER_BACKEND_NAME="\"$name\"" /path/to/file/entrypoint.sh; then
    exit 1
fi

edited Dec 26, 2016 at 0:12

answered Dec 25, 2016 at 23:03

codeforester

43.8k21 gold badges122 silver badges159 bronze badges

Sign up to request clarification or add additional context in comments.

4 Comments

codeforester Over a year ago

@gniourf_gniourf: made changes as per your suggestions. Thanks!

user268396 Over a year ago

@codeforester also: you probably want to use fgrep instead of grep because accidental special regex syntax in $name can do funny things to your grep. Furthermore you also should consider using -x because you want to match the entire line, right? (To avoid false positives from substring matches).

Fred J. Over a year ago

@codeforester this answer failed to exit the script when the line is not found which is what is needed as per the original post.

codeforester Over a year ago

@FredJ. - changed grep to ! grep. That should do it!

Collectives™ on Stack Overflow

Bash file script escaping user input

1 Answer 1

4 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

4 Comments

Your Answer

Sign up or log in

Post as a guest

Related