Sorting function in Python 3

Question

I would like to use an older python script with cmp function, but it doesn't work in Python 3. It raises an error:

TypeError: must use keyword argument for key function

I know that I should avoid the cmp function and use the key function instead, but I don't know how (I don't know Python and I am not a programmer). Could you please help me to change the following part according to this?

ls = list(self.entries)

def func(key1, key2):
    (w1,l1,t1) = res[key1]
    (w2,l2,t2) = res[key2]
    val = cmp((w2,t2), (w1,t1))
    return val
ls.sort(func)

Thank you.

use ls.sort(key=functools.cmp_to_key(func)). sorted docs (list.sort refers to that) and functools docs — Paul Rooney
– Paul Rooney, Commented Jan 4, 2017 at 22:57
Thank you for your response. I tried now, but I received the message: "NameError: name 'functools' is not defined" — Sam
– Sam, Commented Jan 4, 2017 at 22:57
true, I wasn't really looking at his code, just looking at how he could use what he had. — Paul Rooney
– Paul Rooney, Commented Jan 4, 2017 at 23:04
I added the import functools line and now I got the NameError: name 'cmp' is not defined again. Somehow the conversion doesn't work yet. — Sam
– Sam, Commented Jan 4, 2017 at 23:23

Martijn Pieters · Accepted Answer · 2017-01-04 23:25:28Z

3

Just return the first and last element of each tuple you are sorting, but reverse the result:

ls.sort(key=lambda t: (res[t][0], res[t][2]), reverse=True)

That's exactly what the cmp version was comparing on, but in reverse, and the sort() method will do so too.

edited Jan 4, 2017 at 23:25

answered Jan 4, 2017 at 23:01

Martijn Pieters

1.1m326 gold badges4.2k silver badges3.4k bronze badges

Sign up to request clarification or add additional context in comments.

8 Comments

Sam Over a year ago

hmm. I received an "IndexError: string index out of range" message for this code...

Martijn Pieters Over a year ago

@Sam updated, I had missed your code is sorting based on an external mapping res.

Sam Over a year ago

Dear @Martijn Pieters : sorry, I didn't realize you edited your answer. Unfortunately, I am at the same point as before: "NameError: name 'cmp' is not defined" points to the line with val = cmp((w2,t2), (w1,t1)) :(

Martijn Pieters Over a year ago

@Sam my answer doesn't use cmp at all. Remove all of func.

Sam Over a year ago

Ah, I see :) The problem is, that the program tries to call the func function later, and after I removed, I receive a "NameError: name 'func' is not defined" error message.

|

Collectives™ on Stack Overflow

Sorting function in Python 3

1 Answer 1

8 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

8 Comments

Your Answer

Sign up or log in

Post as a guest

Related