unit testing async task in csharp

Question

I'm new to unit testing and async operations in visual studio/c#. Appreciate any help on this.

My Main class

class Foo 
{
    public async Task<string> GetWebAsync()
    {
        using (var client = new HttpClient())
        {
            var response = await client.GetAsync("https://hotmail.com");
            return await response.Content.ReadAsStringAsync();
        }
    }
}

Unit Test

[TestMethod]
public void TestGet()
{
    Foo foo = new Foo();

    foo.GetWebAsync().ContinueWith((k) =>
    {
        Console.Write(k);
        Assert.IsNotNull(null, "error");
    });
}

This piece of code looks odd to me var response = await client.GetAsync("https://hotmail.com"); return await response.Content.ReadAsStringAsync();.....why not two responses and wait all, when all? — Hackerman
– Hackerman, Commented Feb 3, 2017 at 15:25
@Hackerman I'm new and the code is not perfect, can you please help fix it with an answer? — user2727195
– user2727195, Commented Feb 3, 2017 at 15:26
You can create another similar question on codereview.stackexchange.com — Hackerman
– Hackerman, Commented Feb 3, 2017 at 16:03

Nkosi · Accepted Answer · 2017-02-03 16:11:55Z

15

Make the Test async as well

[TestMethod]
public async Task TestGet() {
    var foo = new Foo();
    var result = await foo.GetWebAsync();
    Assert.IsNotNull(result, "error");
    Console.Write(result);
}

edited Feb 3, 2017 at 16:11

answered Feb 3, 2017 at 15:18

Nkosi

249k38 gold badges472 silver badges506 bronze badges

Sign up to request clarification or add additional context in comments.

4 Comments

user2727195 Over a year ago

Thanks it works, quick question, sometimes my Console.Write("..") output appears in TestExplorer besides stack trace (if error) once I select a specific test and sometimes don't, any idea?

user2727195 Over a year ago

Do you think my implementation for GetWebAsync is correct?

Nkosi Over a year ago

@user2727195 for a start it is ok. there is always room for improvement but that leads into a whole other topic of OOP design which is out of scope for this question

Vin Shahrdar Over a year ago

When do we have to call ConfigureAwait(false)?

Collectives™ on Stack Overflow

unit testing async task in csharp

1 Answer 1

4 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

4 Comments

Your Answer

Sign up or log in

Post as a guest

Related