Cannot read property 'then' of undefined AngularJS

Question

I have written a factory method as :

myApp.factory('GetUserCurrentLocationService', ['$q', function ($q) {
            var GetUserCurrentLocationService = {};
            GetUserCurrentLocationService.getLocation = function () {
                var def = $q.defer();
                if (navigator.geolocation) {
                    navigator.geolocation.getCurrentPosition(function (position) {
                        def.resolve(position);
                        return def.promise;
                    });
                }
            }
            return GetUserCurrentLocationService;
        }
    ]);

and in controller I have written:

GetUserCurrentLocationService.getLocation().then(function(response){
        console.log(response);
    },function(error){
        console.log(error);
    })

but whenever i am running this I am getting error Cannot read property 'then' of undefined AngularJS

Satpal · Accepted Answer · 2017-02-08 06:30:19Z

1

As of now your factory getLocation function returns undefined, it's not returning Promise, thus the error is expected. Basically you have misplaced the return def.promise; statement.

GetUserCurrentLocationService.getLocation = function () {
    var def = $q.defer();
    if (navigator.geolocation) {
        navigator.geolocation.getCurrentPosition(function (position) {
            def.resolve(position);
        });         
    } else {
        //Also reject if navigator.geolocation is undefined
        def.reject({});
    }
    //Function should return promised
    return def.promise;
}

answered Feb 8, 2017 at 6:30

Satpal

134k13 gold badges168 silver badges171 bronze badges

Sign up to request clarification or add additional context in comments.

4 Comments

abhit Over a year ago

console.log(response); is still not showing anything

Satpal Over a year ago

@lakshay, Are you getting any data then getCurrentPosition()?

abhit Over a year ago

i don't think so..........suddenly the navigator method has stop working.......it was working before

abhit Over a year ago

is there anything I can do?

Collectives™ on Stack Overflow

Cannot read property 'then' of undefined AngularJS

1 Answer 1

4 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

4 Comments

Your Answer

Sign up or log in

Post as a guest

Related